-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try adding codspeed benchmarks #3421
Conversation
1693259
to
64c2ac1
Compare
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
Looks like the basics are working, I need to add codspeed criterion compatibility as per https://docs.codspeed.io/benchmarks/rust#from-criterionrs |
c54e44e
to
0034ce6
Compare
Also, it seems extremely slow to build the benchmarks 🤔 |
Well, it built and ran! Took 63 minutes but I think that a lot of that is due to release builds, nothing being cached, and GHA runners being pretty slow. I'm going to merge this as an experiment and then we can revisit later whether this was a good idea, if it loads or blocks CI a lot we can remove. |
Closes #3407
I'm curious to see if this works / how it looks like. If it's annoying or noisy we can turn it off.