take control of exception object creation #4669
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea of this PR is to move exception creation out of the Python interpreter (where we can't control it, e.g. all the special cases in #4412), into our own code.
I think this would pave the way for optimisations and maybe relates to #4584 and #4413.
Having started on this, I think for 0.23 it's going to be simpler to just introduce some locking inside
PyErr
, however I would like to revisit this in the future as I think it will be a positive step. So for now I'm just pushing to see impact on benchmarks & tests, and so I don't forget it.