Update pyo3 to 0.22.0 #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoenmaeckers
force-pushed
the
pyo3-0.22.0
branch
from
1201a4b to
41646f5
Compare
|
I've moved all code using the gil-refs api behind the gil-refs feature so it compiles without it as well now. Please review |
|
I'm not sure about the |
bschoenmaeckers
changed the title
|
I am eager to upgrade to PyO3 0.22 but can't until numpy supports it, so let me know if there are any tasks I can take on to help move this forward! Thanks for getting it started :) |
Closed
juntyr
suggested changes
Jul 4, 2024
| @@ -22,12 +22,15 @@ num-complex = ">= 0.2, < 0.5" | |||
| num-integer = "0.1" | |||
| num-traits = "0.2" | |||
| ndarray = ">= 0.13, < 0.16" | |||
| pyo3 = { version = "0.21.0", default-features = false, features = ["macros"] } | |||
| pyo3 = { version = "0.22.0", default-features = false, features = ["macros", "py-clone"] } | |||
There was a problem hiding this comment.
py-clone should not be enabled unconditionally (perhaps behind a forwarding feature as with gil-refs) since it allows potentially panicking clones in any codebase that pulls in numpy as a dependency
This was referenced Jul 14, 2024
|
Closing in fever of #435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first iteration of the process to update to pyo3 0.22. The first step is to make the current code compile against the new version. In following MR we should feature gate the deprecated gil-refs api's used and implement every method against the Bound wrapper.