Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 wishlist #259

Open
davidhewitt opened this issue Jul 2, 2022 · 3 comments
Open

2.0 wishlist #259

davidhewitt opened this issue Jul 2, 2022 · 3 comments

Comments

@davidhewitt
Copy link
Member

davidhewitt commented Jul 2, 2022

Just some tidy-ups I'd like to do whenever we get around to a next breaking release:

  • Change Optional[Sequence[str]] arguments to RustExtension to just be Sequence[str] = ().
  • Remove deprecated options to RustExtension.
  • Remove Binding.Exec (just use RustBin).
  • Require all arguments to RustExtension except for target to be passed as keywords (i.e. after * separator).
  • Remove build_rust subcommand (the setup.py entry point is deprecated, so no need to support it IMO)
  • Remove version.py (just set the corresponding values in __init__.py)
@jameshilliard
Copy link
Contributor

jameshilliard commented Oct 3, 2022

  • Remove build_rust subcommand (the setup.py entry point is deprecated, so no need to support it IMO)

I would recommend holding off on this as it's not currently possible to migrate setuptools setup.py package build infrastructure to pep517 package build infrastructure due to setuptools pep517 support effectively requiring setup.py build infrastructure itself for bootstrapping.

Currently setup.py builds are still supported in the latest setuptools release, IMO we should probably support them here until we start requiring a version of setuptools that no longer supports setup.py style builds.

@davidhewitt
Copy link
Member Author

Thanks for the heads up! I'm in no rush to push forward with a 2.0 release, so potentially we can just wait for upstream before we consider a 2.0 in that case.

@jameshilliard
Copy link
Contributor

  • Remove Binding.Exec (just use RustBin).

I think for embedding binaries in site-packages like in selenium we still may need to keep Binding.Exec as RustBin is only for stuff that goes in the scripts path AFAIU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants