Add a new quasi-functional test using 'multipart' #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppercorn doesn't actually *use* the deprecated stdlib's deprecated 'cgi.FieldStorage', except in a quasi-functional test which builds one only to tear out the name-value pairs to hand to peppercorn's own 'parse'. The rationale here is that peppercorn is mostly used to parse serialized form data, passed in an HTTP POST request body encoded as 'multipart/form-data'. Because 'peppercorn' sits in the part of the WSGI space dependent mostly dominated by 'WebOb', which still using 'cgi.FieldStorage', we have wanted to demonstrate that we could consume such data trivially. However, the 'cgi' module is slated to be removed from the standard library in Python 3.13 (see: https://peps.python.org/pep-0594/#cgi). This branch therefore adds a similar quasi-functionl test, using instead the 'MultipartParser' from the third-party 'multipart' package.
Which is not yet in the 'tox.ini'.
fschulze
reviewed
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
peppercorndoesn't actually use the stdlib's deprecatedcgi.FieldStorage, except in a quasi-functional testwhich builds one only to tear out the name-value pairs to hand to peppercorn's own 'parse'.
The rationale is that
peppercornis mostly used to parse serialized form data, passed in an HTTP POST request body encoded asmultipart/form-data: because 'peppercorn' sits in the part of the WSGI space dependent mostly dominated byWebOb, which still usingcgi.FieldStorage`, we have wanted to demonstrate that we could consume such data trivially.However, the
cgimodule is slated to be removed from the standard library in Python 3.13.This branch therefore adds a similar quasi-functional test, using instead the
MultipartParserfrom the third-partymultipartpackage recommended by PEP-594 as the appropriate replacement forcgi.FieldStorage. Perhaps it might help spark thinking about updates toWebObfor compatibility with Python >= 3.13.