set script name via dict.setdefault()

Pylons · Oct 30, 2023 · 93140ef · 93140ef
1 parent caa7126
commit 93140ef
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 18 deletions.
diff --git a/src/pyramid/scripts/prequest.py b/src/pyramid/scripts/prequest.py
@@ -137,9 +137,7 @@ def run(self):
             return 2
         config_uri = self.args.config_uri
         config_vars = parse_vars(self.args.config_vars)
-        # bw update 2.1 don't overwrite if set
-        if '__script__' not in config_vars:
-            config_vars['__script__'] = self.script_name
+        config_vars.setdefault('__script__', self.script_name)
         path = self.args.path_info
 
         loader = self._get_config_loader(config_uri)

diff --git a/src/pyramid/scripts/proutes.py b/src/pyramid/scripts/proutes.py
@@ -317,9 +317,7 @@ def run(self, quiet=False):
 
         config_uri = self.args.config_uri
         config_vars = parse_vars(self.args.config_vars)
-        # bw update 2.1 don't overwrite if set
-        if '__script__' not in config_vars:
-            config_vars['__script__'] = self.script_name
+        config_vars.setdefault('__script__', self.script_name)
         loader = self.get_config_loader(config_uri)
         loader.setup_logging(config_vars)
         self.proutes_file_config(loader, config_vars)

diff --git a/src/pyramid/scripts/pserve.py b/src/pyramid/scripts/pserve.py
@@ -184,9 +184,7 @@ def run(self):  # pragma: no cover
             return 2
         config_uri = self.args.config_uri
         config_vars = parse_vars(self.args.config_vars)
-        # bw update 2.1 don't overwrite if set
-        if '__script__' not in config_vars:
-            config_vars['__script__'] = self.script_name
+        config_vars.setdefault('__script__', self.script_name)
         app_spec = self.args.config_uri
         app_name = self.args.app_name
 

diff --git a/src/pyramid/scripts/pshell.py b/src/pyramid/scripts/pshell.py
@@ -131,9 +131,7 @@ def run(self, shell=None):
 
         config_uri = self.args.config_uri
         config_vars = parse_vars(self.args.config_vars)
-        # bw update 2.1 don't overwrite if set
-        if '__script__' not in config_vars:
-            config_vars['__script__'] = self.script_name
+        config_vars.setdefault('__script__', self.script_name)
         loader = self.get_config_loader(config_uri)
         loader.setup_logging(config_vars)
         self.pshell_file_config(loader, config_vars)

diff --git a/src/pyramid/scripts/ptweens.py b/src/pyramid/scripts/ptweens.py
@@ -82,9 +82,7 @@ def run(self):
             return 2
         config_uri = self.args.config_uri
         config_vars = parse_vars(self.args.config_vars)
-        # bw update 2.1 don't overwrite if set
-        if '__script__' not in config_vars:
-            config_vars['__script__'] = self.script_name
+        config_vars.setdefault('__script__', self.script_name)
         self.setup_logging(config_uri, global_conf=config_vars)
         env = self.bootstrap(config_uri, options=config_vars)
         registry = env['registry']

diff --git a/src/pyramid/scripts/pviews.py b/src/pyramid/scripts/pviews.py
@@ -249,9 +249,7 @@ def run(self):
             return 2
         config_uri = self.args.config_uri
         config_vars = parse_vars(self.args.config_vars)
-        # bw update 2.1 don't overwrite if set
-        if '__script__' not in config_vars:
-            config_vars['__script__'] = self.script_name
+        config_vars.setdefault('__script__', self.script_name)
         url = self.args.url
 
         self.setup_logging(config_uri, global_conf=config_vars)