Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pypy by using a specific version #3183

Merged
merged 1 commit into from
Oct 22, 2017
Merged

fix pypy by using a specific version #3183

merged 1 commit into from
Oct 22, 2017

Conversation

mmerickel
Copy link
Member

No description provided.

@mmerickel
Copy link
Member Author

======================================================================
ERROR: test_instance_conforms (pyramid.tests.test_events.TestBeforeRender)
----------------------------------------------------------------------
Traceback (most recent call last):
 File "/home/travis/build/Pylons/pyramid/pyramid/tests/test_events.py", line 242, in test_instance_conforms
 verifyObject(IBeforeRender, event)
 File "/home/travis/build/Pylons/pyramid/.tox/pypy/site-packages/zope/interface/verify.py", line 105, in verifyObject
 return _verify(iface, candidate, tentative, vtype='o')
 File "/home/travis/build/Pylons/pyramid/.tox/pypy/site-packages/zope/interface/verify.py", line 97, in _verify
 raise BrokenMethodImplementation(name, mess)
BrokenMethodImplementation: The implementation of pop violates its contract
 because implementation requires too many arguments.

@mmerickel
Copy link
Member Author

mmerickel commented Oct 22, 2017

Ok I bisected pypy versions and found that the tests pass on 5.4.1 and fail on 5.6.0, 5.7.0 and 5.7.1.

@mmerickel
Copy link
Member Author

@mmerickel mmerickel closed this Oct 22, 2017
@mmerickel mmerickel reopened this Oct 22, 2017
@mmerickel mmerickel merged commit cc341a6 into master Oct 22, 2017
mmerickel added a commit that referenced this pull request Oct 22, 2017
mmerickel added a commit that referenced this pull request Oct 22, 2017
mmerickel added a commit that referenced this pull request Oct 22, 2017
mmerickel added a commit that referenced this pull request Oct 22, 2017
@mmerickel mmerickel deleted the fix-pypy branch October 22, 2017 06:08
@tseaver
Copy link
Member

tseaver commented Mar 8, 2018

@mmerickel on the PyPy issue, you say we have a bug in IDict -- I can't find that bug here, or a fix for it. Ideally, we would fix the bug and then un-pin the PyPy version in .travis.yml.

@mmerickel
Copy link
Member Author

mmerickel commented Mar 8, 2018 via email

@tseaver
Copy link
Member

tseaver commented Mar 9, 2018

@mmerickel I didn't expect that you had fixed it: I just wondered if I had missed where you opened the bug against Pyramid (since you agreed on the Bitbucket issue that we have a bug).

@mmerickel
Copy link
Member Author

thanks @tseaver I opened #3237 to track it now.

@digitalresistor
Copy link
Member

I may not be understanding the issue correctly, but I am not sure how using marker would change anything since it's z.i that needs to understand about the non-normal dict.pop.

@mmerickel
Copy link
Member Author

mmerickel commented Mar 9, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants