Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update versions of GitHub Actions #227

Merged
merged 2 commits into from
Mar 13, 2024
Merged

chore: update versions of GitHub Actions #227

merged 2 commits into from
Mar 13, 2024

Conversation

miketheman
Copy link
Collaborator

These are using deprecated runtimes.
See: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman requested a review from zupo March 13, 2024 20:18
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman
Copy link
Collaborator Author

Interesting - we get a race condition on uploading coverage:

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

Refs: https://github.com/actions/upload-artifact/blob/ef09cdac3e2d3e60d8ccadda691f4f1cec5035cb/docs/MIGRATION.md#overwriting-an-artifact

Instead of overwriting, preserve the coverage report under another name

Copy link
Collaborator

@zupo zupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@miketheman miketheman merged commit 0fc70de into main Mar 13, 2024
3 checks passed
@miketheman miketheman deleted the update-actions branch March 13, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants