fix(extract_errors): fix wrong field being emitted when extracting several errors for a single object #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…veral errors for a same object The `field` variable was used both as the function argument and as a local variable that was not intended to be reused between iterations. Renaming the function argument fixes this problem since its value is no longer modified between iterations.
fbessou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fieldvariable was used both as the function argument and as a local variable that was not intended to be reused between iterations.Renaming the function argument fixes this problem since its value is no longer modified between iterations.
You can take a look at the test BadRequestsTests.test_multiple_errors which contained an inconsistency :
a string was passed as value for the "bam" parameter whose schema was typed as "integer". The error was reported on "baz" instead of "bam".