Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tox.ini #28

Closed
wants to merge 1 commit into from
Closed

Remove tox.ini #28

wants to merge 1 commit into from

Conversation

zupo
Copy link
Collaborator

@zupo zupo commented Jul 23, 2019

It hasn't been touched in a year and I doubt it still works.

It hasn't been touched in a year and I doubt it still works.
@digitalresistor
Copy link
Member

I would recommend updating it instead, having a tox.ini is the way that I as a developer run tests for WebOb, Pyramid, Waitress and more. Feel free to steal from those. It is especially important for libraries we want people to consume, we want to test them across a wide range of python versions and platforms, and it is easy to plug tox into various build platform matrices.

@zupo
Copy link
Collaborator Author

zupo commented Jul 24, 2019

@bertjwregeer: I'm not against it, but I can't seem to be able to learn to use tox and so I can't update it. I've tried several times, including a few months back when prepping pyramid_openapi3 for release. It just fails on my machine with strange errors.

What I'm trying to say is: 1. it's not realistic for me to bring tox.ini to a workable state (and if it is workable, then it should be used in CI as well so it remains workable). -> it's better to remove it than to have a very outdated and broken tox.ini. If someone wants to tackle it, I'm all for it, but until then, it's probably best to remove it.

@stevepiercy
Copy link
Member

Which parts from the makefile would you want to port to tox?

Do you want to test on 3.8 with an allowed failure, as well as must pass on 3.7?

Do you want to test on pypy3?

Do you want to use appveyor to test on Windows?

I know just enough to be dangerous, and I couldn't break tox more than it is borken now, so what the heck, why not take a stab at it?

@zupo
Copy link
Collaborator Author

zupo commented Jul 24, 2019

Which parts from the makefile would you want to port to tox?

Ideally, none. I'm really used to Makefiles.

Do you want to test on 3.8 with an allowed failure, as well as must pass on 3.7?

If we're testing, I'd say it needs to pass, no allowed failures.

Do you want to test on pypy3?

Personally, no. Not against it if someone needs it.

Do you want to use appveyor to test on Windows?

Personally, no. Not against it if someone needs it.

I know just enough to be dangerous, and I couldn't break tox more than it is borken now, so what the heck, why not take a stab at it?

:)

@zupo
Copy link
Collaborator Author

zupo commented Jul 31, 2019

@stevepiercy: any luck?

@stevepiercy
Copy link
Member

Swamped through Friday.

@stevepiercy
Copy link
Member

stevepiercy commented Aug 4, 2019

Let's close this PR and focus on a new minimal PR #30 that now works.

@zupo zupo closed this Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants