-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tox.ini #28
Remove tox.ini #28
Conversation
It hasn't been touched in a year and I doubt it still works.
I would recommend updating it instead, having a |
@bertjwregeer: I'm not against it, but I can't seem to be able to learn to use tox and so I can't update it. I've tried several times, including a few months back when prepping pyramid_openapi3 for release. It just fails on my machine with strange errors. What I'm trying to say is: 1. it's not realistic for me to bring |
Which parts from the makefile would you want to port to tox? Do you want to test on 3.8 with an allowed failure, as well as must pass on 3.7? Do you want to test on pypy3? Do you want to use appveyor to test on Windows? I know just enough to be dangerous, and I couldn't break tox more than it is borken now, so what the heck, why not take a stab at it? |
Ideally, none. I'm really used to Makefiles.
If we're testing, I'd say it needs to pass, no allowed failures.
Personally, no. Not against it if someone needs it.
Personally, no. Not against it if someone needs it.
:) |
@stevepiercy: any luck? |
Swamped through Friday. |
Let's close this PR and focus on a new minimal PR #30 that now works. |
It hasn't been touched in a year and I doubt it still works.