Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Partial Entropic FGW solvers #702

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

cedricvincentcuaz
Copy link
Collaborator

@cedricvincentcuaz cedricvincentcuaz commented Nov 27, 2024

Types of changes

  • Implement Entropic partial FGW solvers using projected gradient descent in ot.gromov.entropic_partial_fused_gromov_wasserstein and ot.gromov.entropic_partial_fused_gromov_wasserstein2.
  • Add these solvers to ot.solve_gromov. Add a warning when unbalanced=None and unbalanced_type="partial".
  • New exemples with (entropic) Partial GW and FGW in examples/gromov/plot_partial_fgw.py

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 98.86364% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.08%. Comparing base (200322b) to head (c3264c1).

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #702    +/-   ##
========================================
  Coverage   97.08%   97.08%            
========================================
  Files          98       98            
  Lines       19937    20105   +168     
========================================
+ Hits        19355    19519   +164     
- Misses        582      586     +4     

ot/gromov/_partial.py Outdated Show resolved Hide resolved
ot/gromov/_partial.py Outdated Show resolved Hide resolved
ot/gromov/_partial.py Outdated Show resolved Hide resolved
@cedricvincentcuaz cedricvincentcuaz changed the title [WIP] Partial Entropic FGW solvers [MRG] Partial Entropic FGW solvers Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants