Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code to not raise any FutureWarnings #190

Open
patrickleonardy opened this issue Nov 28, 2023 · 0 comments · May be fixed by #191
Open

Update code to not raise any FutureWarnings #190

patrickleonardy opened this issue Nov 28, 2023 · 0 comments · May be fixed by #191
Assignees
@patrickleonardy

Comments

@patrickleonardy
Copy link
Contributor

patrickleonardy commented Nov 28, 2023 •
edited
Loading

Update code to not raise any FutureWarnings

Some code in the Cobra library raises FutureWarnings.

Task Description

Change the code such that those FutureWarnings do not end up generating problem later

FutureWarnings

tests/preprocessing/test_target_encoder.py::TestTargetEncoder::test_target_encoder_transform_new_category_linear_regression_median
/home/patrick/github_projects/work/cobra/tests/preprocessing/test_target_encoder.py:312: FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.
df_appended = df.append({"variable": "new", "target": 10},

tests/preprocessing/test_target_encoder.py::TestTargetEncoder::test_target_encoder_transform_new_category_binary_classification_median
/home/patrick/github_projects/work/cobra/tests/preprocessing/test_target_encoder.py:338: FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.
df_appended = df.append({"variable": "new", "target": 1},
@patrickleonardy patrickleonardy self-assigned this Nov 28, 2023
@patrickleonardy patrickleonardy linked a pull request Nov 28, 2023 that will close this issue
Open
@patrickleonardy patrickleonardy linked a pull request Nov 28, 2023 that will close this issue
fix(FutureWarnings): replace .append by pd.concat #191
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickleonardy patrickleonardy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(FutureWarnings): replace .append by pd.concat PythonPredictions/cobra
1 participant
@patrickleonardy