Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #417: Abstract the Qbeast Snapshot Module #411

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

JosepSampe
Copy link
Member

Description

This is a small initial part of issue #398.

The aim of this PR is to allow the DeltaQbeastSnapshot to accept the tableID as an input parameter instead of a Delta snapshot. This will make the top-level QbeastSnapshot class more abstract and enable better integration with other table formats.

Related tests have also been adapted to remove the strict dependency on org.apache.spark.sql.delta.DeltaLog. In the future, the tests will instantiate a QbeastSnapshot instead of a DeltaQbeastSnapshot to make them more generic.

Type of change

Refactoring

Checklist:

Here is the list of things you should do before submitting this pull request:

  • New feature / bug fix has been committed following the Contribution guide.
  • Add logging to the code following the Contribution guide.
  • Add comments to the code (make it easier for the community!).
  • Change the documentation.
  • Add tests.
  • Your branch is updated to the main branch (dependent changes have been merged).

@JosepSampe JosepSampe self-assigned this Sep 12, 2024
Copy link
Member

@cugni cugni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. I like that this PR also solve another issue, when we were reloading the deltaLog multiple times in the IndexTables, instead of only once for each QbeastStapshot

@osopardo1 osopardo1 changed the base branch from main to refactor September 16, 2024 09:38
Copy link
Member

@osopardo1 osopardo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging and approving the PR, I would ask to add an issue with the scope and link the specific number instead of #398 🙏

Also, some other comments to be resolved:

build.sbt Show resolved Hide resolved
@JosepSampe JosepSampe changed the title Issue #398: Change DeltaQbeastSnapshot parameters Issue #417: Abstract the Qbeast Snapshot Module Sep 16, 2024
@osopardo1 osopardo1 merged commit 746a307 into Qbeast-io:refactor Sep 16, 2024
1 check passed
@JosepSampe JosepSampe deleted the refactoring branch September 16, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants