Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New guides page for circuit cutting addon #2558

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

kaelynj
Copy link
Collaborator

@kaelynj kaelynj commented Jan 9, 2025

Closes #2114 and closes #2115

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

The guides pages for the circuit cutting addon should have two get
started guides based on the package tutorials. One for wire cutting and
another for gate cutting.
@kaelynj
Copy link
Collaborator Author

kaelynj commented Jan 14, 2025

Ok @abbycross just finished addressing all these changes. Feel free to give it another look.

I've also added in a diagram I modified from the circuit cutting paper to match the circuit cutting blog

@abbycross
Copy link
Collaborator

Ok @abbycross just finished addressing all these changes. Feel free to give it another look.

Will do! I hadn't quite finished going through the mdx file either, so I'll check that out too

Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final cleanup comments - otherwise looks good!!

Co-authored-by: abbycross <across@us.ibm.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EfficientSU2 is deprecated

https://docs.quantum.ibm.com/api/qiskit/qiskit.circuit.library.EfficientSU2

The efficient_su2() function constructs a functionally equivalent circuit, but faster.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I've switched to the efficient_su2() function instead.

@@ -0,0 +1,433 @@
{
Copy link
Member

@garrison garrison Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to link PauliList to its API doc page?


Reply via ReviewNB

@@ -0,0 +1,335 @@
{
Copy link
Member

@garrison garrison Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one part of the first paragraph that references something I don't see in this guide:

and reducing circuit depth and width using gate cutting.

Should this part be removed?


Reply via ReviewNB

@@ -0,0 +1,335 @@
{
Copy link
Member

@garrison garrison Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might actually be better to start this guide with a cut_wires example, before demonstrating qubit re-use by explicitly placing Move operations.


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I've reorded the sections and made some substantial changes on this page to help make it flow better for the reader. Would you mind re-reviewing the content to make sure I don't have any information wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[ NEW GUIDE] circuit cutting get started [ NEW GUIDE ] circuit cutting intro
3 participants