Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Commit

Permalink
Merge pull request #196 from Qoraiche/refac/improve-error-handling
Browse files Browse the repository at this point in the history
Refac/improve error handling and feedback
  • Loading branch information
ReeceM authored Feb 10, 2022
2 parents abda19b + 25cc88c commit 76992f8
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/node_modules/*
node_modules/*
.DS_Store
/vendor
/composer.lock
Expand All @@ -10,3 +10,5 @@ resources/views/draft/*
# exception to the rule
!resources/views/draft/.gitkeep
!resources/views/templates/.gitkeep

docs/node_modules
6 changes: 6 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -265,3 +265,9 @@ New Structure:

### Fixes
- Fixes an issue where in some cases Faker data would cause a issue for the javascript frontend. See #187 and #188

## Version 4.0.0

### Changed

Laravel 9 Support
6 changes: 4 additions & 2 deletions src/MailEclipse.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class MailEclipse
{
public const VIEW_NAMESPACE = 'maileclipse';

public const VERSION = '3.5.0';
public const VERSION = '4.0.1';

/**
* Default type examples for being passed to reflected classes.
Expand Down Expand Up @@ -934,7 +934,9 @@ private static function resolveFactory($eloquentFactory, $model): ?object
return $model::factory()->make();
}

return null;
$action = sprintf('php artisan make:factory %sFactory --model=%s', Str::of($model)->afterLast('\\'), $model);

throw new \Exception("No Factory found, maileclipse.factory config is true. But there is no Factory. Create using $action");
}

/**
Expand Down

0 comments on commit 76992f8

Please sign in to comment.