fix: msvc and release is a build failure

[XMuli]

No description provided.

[XMuli]

Of course deleting the following two lines directly will also fail to compile. Although it is a bit strange.

[XMuli]

When switching to release, it will show that this macro is not defined. It is a bit inconsistent with the definition here

qtacrylicmaterial/src/CMakeLists.txt

Line 62 in a04c19a

QTACRYLICHELPER_BUILD_LIBRARY

[moodyhunter]

I suspect this would be an incorrect fix :(
see also the template file from https://codereview.qt-project.org/c/qt/qtbase/+/356214

[XMuli]

@moodyhunter But it does fail to compile (me too 😅)

Win10 21H2 + MSVC(2019) + Release

[moodyhunter]

strange. but I'm on a holiday trip, will investigate a bit once I'm back home.

[moodyhunter]

It seems that for a static build, QTACRYLICHELPER_STATIC isn't defined properly as it should be.

[moodyhunter]

@XMuli can you try adding...

if(NOT BUILD_SHARED_LIBS)
    target_compile_definitions(${PROJECT_NAME} PUBLIC QTACRYLICHELPER_STATIC)
endif()

to src/CMakeLists.txt and try rebuilding?

Note the PUBLIC keyword is required to populate this macro define to a downstream user project (that are, the ones under examples/)

[XMuli]

It is running successfully. @moodyhunter thanks

But I am confused as follows:

qtacrylicmaterial/src/CMakeLists.txt

Line 43 in a04c19a

if(BUILD_SHARED_LIBS)

BUILD_SHARED_LIBS is ON by default and generates shared (not static), why does it become static under release?

[moodyhunter]

I haven't experienced that before...
Can you try performing a clean build and verifying CMAKE_BUILD_TYPE and BUILD_SHARED_LIBS in CMakeCache.txt?

[XMuli]

Okay, I'll try it when I get home tonight

[XMuli]

The test is as follows（Win10 + VS2019 + CMake 3.3）
BUILD_SHARED_LIBS is OFF by default.

ON: Generate (.dll + .exp + .lib)
OFF: Generate (.lib)

[XMuli]

Modified the commit to generate .dll by default

to avoid direct run failures and confusion

[moodyhunter]

may it be wrapped by an if check?

[XMuli]

What to calibrate?😰

If you want to generate .lib manually change it to OFF.