Remove build artifacts from the repo #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gabalafou
commented
Feb 21, 2024
docs/index.css
Outdated
There was a problem hiding this comment.
I just felt like moving these styles out of index.html
| <option>gotthard-dark</option> | ||
| <option>blinds-light</option> | ||
| <option>blinds-dark</option> | ||
| <option>greative</option> |
There was a problem hiding this comment.
Will need to automate this list of themes somehow. Maybe we'll make this index.html file a Jinja template?
|
Do we know why PR-preview (GitHub action) doesn't work? |
trallard
reviewed
Mar 27, 2024
trallard
reviewed
Mar 27, 2024
trallard
reviewed
Mar 27, 2024
trallard
reviewed
Mar 27, 2024
trallard
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Thanks @gabalafou, this looks great and helps make this repo a lot more maintainable.
Made a couple of small changes (pushed) and suggestions, if you are happy with these we can merge right away.
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
No, this is still an open problem. The Jinja template in the other PRs is used to generate the theme READMEs, but not the demo index.html page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all of the generated HTML and CSS from the repo and refactors the build scripts.
There is perhaps an argument for committing built examples to the repo. That way a user can open the demo page from their own local repo into their browser without having to execute any build command first. But we can add that later if we want.
My goal is to make the repo easier to understand by stripping it of everything but READMEs, config files, source code, scripts, and tests.
My ultimate goal is to simplify and automate the process of updating or adding a theme. This PR helps that goal by removing steps 2, 3, and 4 from the list of steps in issue #34. The trade-off that this PR makes to achieve that goal is that the docs/index.html file can no longer be opened locally from the repo and just work (to make it work locally, developers will need to run the
render_htmlcommand). Subsequent PRs will automate steps 5 and 6, so that updating a theme will involve the following steps: