Merge pull request #174 from asmeurer/slotscheck

Run slotscheck on CI

.github/workflows/tests.yml

@@ -21,14 +21,23 @@ jobs:
         run: |
           set -x
           set -e
-          python -m pip install pyflakes pytest pytest-doctestplus hypothesis pytest-cov pytest-flakes packaging
+          python -m pip install -r requirements-dev.txt
           if [[ ${{ matrix.numpy-version }} == 'latest' ]]; then
               python -m pip install --upgrade numpy
           elif [[ ${{ matrix.numpy-version }} == 'dev' ]]; then
               python -m pip install --pre --upgrade --extra-index https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy
           else
               python -m pip install --upgrade numpy==${{ matrix.numpy-version }}.*
           fi
+      - name: Run Doctests
+        run: |
+          ./run_doctests
+      - name: Test Installation
+        run: |
+          python -m pip install .
+      - name: Run Slotscheck
+        run: |
+          python -m slotscheck ndindex
       # Enable experimental faster sys.monitoring coverage for Python 3.12
       - name: Set COVERAGE_CORE=sysmon
         run: echo "COVERAGE_CORE=sysmon" >> $GITHUB_ENV
@@ -42,9 +51,6 @@ jobs:
           # The coverage requirement check is done by the coverage report line below
           PYTEST_FLAGS="$PYTEST_FLAGS -v --cov-fail-under=0";
           pytest $PYTEST_FLAGS
-          ./run_doctests
-          # Make sure it installs
-          pip install .
           # Coverage. This also sets the failing status if the
           # coverage is not 100%. Travis sometimes cuts off the last command, which is
           # why we print stuff at the end.

ndindex/shapetools.py

@@ -12,8 +12,6 @@ class BroadcastError(ValueError):
     compatible.
 
     """
-    __slots__ = ("arg1", "shape1", "arg2", "shape2")
-
     def __init__(self, arg1, shape1, arg2, shape2):
         self.arg1 = arg1
         self.shape1 = shape1
@@ -33,8 +31,6 @@ class AxisError(ValueError, IndexError):
     `iter_indices` does not need to depend on NumPy.
 
     """
-    __slots__ = ("axis", "ndim")
-
     def __init__(self, axis, ndim):
         # NumPy allows axis=-1 for 0-d arrays
         if (ndim < 0 or -ndim <= axis < ndim) and not (ndim == 0 and axis == -1):

ndindex/tests/test_integer.py

@@ -68,6 +68,7 @@ def test_integer_reduce_exhaustive():
                 assert reduced.reduce(**kwargs) == reduced
                 assert reduced.reduce(10, **kwargs) == reduced
 
+@example(0, (1,), {'negative_int': True})
 @given(ints(), shapes, reduce_kwargs)
 def test_integer_reduce_hypothesis(i, shape, kwargs):
     a = arange(prod(shape)).reshape(shape)

requirements-dev.txt

@@ -6,3 +6,4 @@ pytest
 pytest-cov
 pytest-doctestplus
 pytest-flakes
+slotscheck