-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple skip axes in iter_indices and broadcast_shapes #155
Support multiple skip axes in iter_indices and broadcast_shapes #155
Commits on Apr 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e44f7a2 - Browse repository at this point
Copy the full SHA e44f7a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c3a75f - Browse repository at this point
Copy the full SHA 9c3a75fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15bcade - Browse repository at this point
Copy the full SHA 15bcadeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 428f1f5 - Browse repository at this point
Copy the full SHA 428f1f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for de7661e - Browse repository at this point
Copy the full SHA de7661eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 46b0831 - Browse repository at this point
Copy the full SHA 46b0831View commit details -
Configuration menu - View commit details
-
Copy full SHA for d59f000 - Browse repository at this point
Copy the full SHA d59f000View commit details
Commits on May 2, 2023
-
Update mutually_broadcastable_shapes_with_skip_axes to generate lists…
… of skip_axes This changes the way the strategy is generated to construct skip_axes and a result shape first, then generate shapes that match those skip axes and broadcast to the result shape. It doesn't attempt to directly use mutually_broadcastable_shapes. This is unfortunate, and it does require a little bit of filtering, but it is the only way that I could figure out how to generate the full range of possible examples. skip_axes_st is now always generated in conjunction with this strategy, as 1) generating the skip axes first and then the shapes doesn't seem to work, and 2) the two strategies are always used together anyway. This doesn't yet update all the tests that use this (nor are the functions themselves updated), but test_mutually_broadcastable_shapes_with_skip_axes() passes.
Configuration menu - View commit details
-
Copy full SHA for 2f2399e - Browse repository at this point
Copy the full SHA 2f2399eView commit details
Commits on May 7, 2023
-
No longer add None indices in the return value of broadcast_shapes wi…
…th skip_axes This is impossible to do in general if we allow both negative and nonnegative skip_axes, and it's also too complex to check the result shape skip axes to make sure they are consistent. Unfortunately, this is a backwards compatibility break, but hopefully no one is actually using this function yet.
Configuration menu - View commit details
-
Copy full SHA for 29b2122 - Browse repository at this point
Copy the full SHA 29b2122View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a6c9f1 - Browse repository at this point
Copy the full SHA 2a6c9f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d4202e - Browse repository at this point
Copy the full SHA 6d4202eView commit details
Commits on May 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8007c64 - Browse repository at this point
Copy the full SHA 8007c64View commit details
Commits on May 25, 2023
-
Update iter_indices to support arbitrary skip_axes
This also changes the definition of the internal associated_axis() function.
Configuration menu - View commit details
-
Copy full SHA for a45b3ca - Browse repository at this point
Copy the full SHA a45b3caView commit details -
Update test_iter_indices to handle arbitrary skip_axes
The testing strategy is changed a little bit. We just test against the broadcasted arrays with the skip axes removed, since the number of skip axes is not necessarily uniform across the shapes anymore.
Configuration menu - View commit details
-
Copy full SHA for 2eb0932 - Browse repository at this point
Copy the full SHA 2eb0932View commit details -
Only generate slices for completely skipped shapes once.
Configuration menu - View commit details
-
Copy full SHA for 053c14a - Browse repository at this point
Copy the full SHA 053c14aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7da16da - Browse repository at this point
Copy the full SHA 7da16daView commit details
Commits on Jun 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a75e1bc - Browse repository at this point
Copy the full SHA a75e1bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38b784d - Browse repository at this point
Copy the full SHA 38b784dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6ca2a6 - Browse repository at this point
Copy the full SHA c6ca2a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06b00bd - Browse repository at this point
Copy the full SHA 06b00bdView commit details
Commits on Jul 27, 2023
-
It is (hopefully) actually correct now with the new definition for skip_axes.
Configuration menu - View commit details
-
Copy full SHA for d81d081 - Browse repository at this point
Copy the full SHA d81d081View commit details
Commits on Jul 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6fe3ce3 - Browse repository at this point
Copy the full SHA 6fe3ce3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0537c1 - Browse repository at this point
Copy the full SHA c0537c1View commit details
Commits on Aug 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 38a6ab0 - Browse repository at this point
Copy the full SHA 38a6ab0View commit details -
Configuration menu - View commit details
-
Copy full SHA for dac60d1 - Browse repository at this point
Copy the full SHA dac60d1View commit details
Commits on Aug 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cbd3f30 - Browse repository at this point
Copy the full SHA cbd3f30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1397242 - Browse repository at this point
Copy the full SHA 1397242View commit details -
Merge branch 'iter_indices-multi-skip_axes' of github.com:asmeurer/nd…
…index into iter_indices-multi-skip_axes
Configuration menu - View commit details
-
Copy full SHA for 7fc71de - Browse repository at this point
Copy the full SHA 7fc71deView commit details -
Configuration menu - View commit details
-
Copy full SHA for b163c2c - Browse repository at this point
Copy the full SHA b163c2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1166f11 - Browse repository at this point
Copy the full SHA 1166f11View commit details -
Configuration menu - View commit details
-
Copy full SHA for abde062 - Browse repository at this point
Copy the full SHA abde062View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbd4bf5 - Browse repository at this point
Copy the full SHA cbd4bf5View commit details
Commits on Jan 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b18b127 - Browse repository at this point
Copy the full SHA b18b127View commit details -
Configuration menu - View commit details
-
Copy full SHA for d155cff - Browse repository at this point
Copy the full SHA d155cffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 012792d - Browse repository at this point
Copy the full SHA 012792dView commit details
Commits on Jan 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a565cd0 - Browse repository at this point
Copy the full SHA a565cd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bc92da - Browse repository at this point
Copy the full SHA 9bc92daView commit details
Commits on Jan 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a6cfbbb - Browse repository at this point
Copy the full SHA a6cfbbbView commit details
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 72b71ca - Browse repository at this point
Copy the full SHA 72b71caView commit details