Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple skip axes in iter_indices and broadcast_shapes #155

Merged
merged 39 commits into from
Feb 1, 2024

Commits on Apr 24, 2023

  1. Configuration menu
    Copy the full SHA
    e44f7a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c3a75f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    15bcade View commit details
    Browse the repository at this point in the history
  4. Add some @examples for coverage

    asmeurer committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    428f1f5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    de7661e View commit details
    Browse the repository at this point in the history
  6. Add a test for coverage

    asmeurer committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    46b0831 View commit details
    Browse the repository at this point in the history
  7. Add a TODO comment

    asmeurer committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    d59f000 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Update mutually_broadcastable_shapes_with_skip_axes to generate lists…

    … of skip_axes
    
    This changes the way the strategy is generated to construct skip_axes and a
    result shape first, then generate shapes that match those skip axes and
    broadcast to the result shape. It doesn't attempt to directly use
    mutually_broadcastable_shapes. This is unfortunate, and it does require a
    little bit of filtering, but it is the only way that I could figure out how to
    generate the full range of possible examples. skip_axes_st is now always
    generated in conjunction with this strategy, as 1) generating the skip axes
    first and then the shapes doesn't seem to work, and 2) the two strategies are
    always used together anyway.
    
    This doesn't yet update all the tests that use this (nor are the functions
    themselves updated), but test_mutually_broadcastable_shapes_with_skip_axes()
    passes.
    asmeurer committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2f2399e View commit details
    Browse the repository at this point in the history

Commits on May 7, 2023

  1. No longer add None indices in the return value of broadcast_shapes wi…

    …th skip_axes
    
    This is impossible to do in general if we allow both negative and nonnegative
    skip_axes, and it's also too complex to check the result shape skip axes to
    make sure they are consistent.
    
    Unfortunately, this is a backwards compatibility break, but hopefully no one
    is actually using this function yet.
    asmeurer committed May 7, 2023
    Configuration menu
    Copy the full SHA
    29b2122 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2a6c9f1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6d4202e View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Configuration menu
    Copy the full SHA
    8007c64 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Update iter_indices to support arbitrary skip_axes

    This also changes the definition of the internal associated_axis() function.
    asmeurer committed May 25, 2023
    Configuration menu
    Copy the full SHA
    a45b3ca View commit details
    Browse the repository at this point in the history
  2. Update test_iter_indices to handle arbitrary skip_axes

    The testing strategy is changed a little bit. We just test against the
    broadcasted arrays with the skip axes removed, since the number of skip axes
    is not necessarily uniform across the shapes anymore.
    asmeurer committed May 25, 2023
    Configuration menu
    Copy the full SHA
    2eb0932 View commit details
    Browse the repository at this point in the history
  3. Fix an issue in iter_indices

    Only generate slices for completely skipped shapes once.
    asmeurer committed May 25, 2023
    Configuration menu
    Copy the full SHA
    053c14a View commit details
    Browse the repository at this point in the history
  4. Fix a bug in associated_axis

    asmeurer committed May 25, 2023
    Configuration menu
    Copy the full SHA
    7da16da View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Configuration menu
    Copy the full SHA
    a75e1bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    38b784d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c6ca2a6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    06b00bd View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Rewrite iter_indices()

    It is (hopefully) actually correct now with the new definition for skip_axes.
    asmeurer committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d81d081 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    6fe3ce3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c0537c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Improve test coverage

    asmeurer committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    38a6ab0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dac60d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Configuration menu
    Copy the full SHA
    cbd3f30 View commit details
    Browse the repository at this point in the history
  2. Update documentation

    asmeurer committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1397242 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'iter_indices-multi-skip_axes' of github.com:asmeurer/nd…

    …index into iter_indices-multi-skip_axes
    asmeurer committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    7fc71de View commit details
    Browse the repository at this point in the history
  4. Add an example for coverage

    asmeurer committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    b163c2c View commit details
    Browse the repository at this point in the history
  5. Add an example for coverage

    asmeurer committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1166f11 View commit details
    Browse the repository at this point in the history
  6. Fix coverage example

    asmeurer committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    abde062 View commit details
    Browse the repository at this point in the history
  7. Fix coverage

    asmeurer committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    cbd4bf5 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Configuration menu
    Copy the full SHA
    b18b127 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d155cff View commit details
    Browse the repository at this point in the history
  3. Add an @example for coverage

    asmeurer committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    012792d View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Add requirements-dev.txt

    asmeurer committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    a565cd0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9bc92da View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Fix doctests

    asmeurer committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a6cfbbb View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Add an example for coverage

    asmeurer committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    72b71ca View commit details
    Browse the repository at this point in the history