Add pre-commit config and autofix CI #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a `pre-commit` config and a Github action to autofix using pre-commit. This has been working well in practice in our other repo `free-threading-compatibility`. - Adds `tox` and `pre-commit` as dev dependencies to be able to run everything without needing to install anything else. - Removes `ruff` from the tox envs that run in the Github action since it'll run as part of the pre-commit CI. Again, feel free to say no if it's too much.
|
Note: If we decide to go with it, we need to change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commitconfig and a Github action to autofix using pre-commit. This has been working well in practice in our other repofree-threading-compatibility.toxandpre-commitas dev dependencies to be able to run everything without needing to install anything else.rufffrom the tox envs that run in the Github action since it'll run as part of the pre-commit CI.Again, feel free to say no if it's too much.