Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post on SymPy Documentation #794

Merged
merged 66 commits into from
Oct 31, 2023
Merged

Blog post on SymPy Documentation #794

merged 66 commits into from
Oct 31, 2023

Conversation

asmeurer
Copy link
Member

I still need some help here with cleaning up the formatting and the metadata. Feel free to push up changes directly to my branch.

I'd like to get this posted by the end of the month if possible so that I can reference it in our grant report to CZI.

Text styling

  • The blog is written with plain language (where relevant).
  • If there are headers, they use the proper header tags in order to do so (with only one level-one header).
  • All links describe where they link to (for example, check the Quansight labs website).
  • Any kind of styling that the author uses (for example, bold for emphasis) is consistent throughout the blog.

Non-text contents

  • Blog post featured image is in PNG or JPEG format, not SVG.
  • All content is represented as text (for example, images need alt text and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing gifs or videos.
  • If it were to be read as plain text, the blog still makes sense and no information is missing.

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
labs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 6:57pm

Copy link
Contributor

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really clear and easy to follow, great job!

Most of my suggestions are about changing which text you hyperlink because I think a lot nowadays about how links show up in assistive tech. I strive to make pages so that if you pull out all of the links in a list separate from the page, the links will still mostly make sense.

apps/labs/posts/sympy_documentation.md Outdated Show resolved Hide resolved
apps/labs/posts/sympy_documentation.md Outdated Show resolved Hide resolved
apps/labs/posts/sympy_documentation.md Outdated Show resolved Hide resolved
apps/labs/posts/sympy_documentation.md Outdated Show resolved Hide resolved
apps/labs/posts/sympy_documentation.md Outdated Show resolved Hide resolved
apps/labs/posts/sympy_documentation.md Outdated Show resolved Hide resolved
apps/labs/posts/sympy_documentation.md Outdated Show resolved Hide resolved
Comment on lines 78 to 79
3. We were been able to identify some primary areas of documentation that
to prioritize for writing new documentation guides.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such as? Should you list them here?

Comment on lines 34 to 36
three main takeaways of the survey were:

1. The main SymPy documentation site (https://docs.sympy.org) is overwhelmingly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if instead of having this long form content live in the format of a list, if it would be more reader-friendly to give a shorthand version of the content in a short list and then follow into what you've written below, like so:

Suggested change
three main takeaways of the survey were:
1. The main SymPy documentation site (https://docs.sympy.org) is overwhelmingly
three main takeaways of the survey were:
1. SymPy's own documentation site is more popular than other resources such as StackOverflow.
2. Organization and layout needed improvement.
3. The community wanted new documentation areas.
The main SymPy documentation site (https://docs.sympy.org) is overwhelmingly

Something like that

written that outlines a deprecation policy. This guide brings three new things
to SymPy:

- A clear policy on when backwards compatibility breaks should be made. The
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be just a personal preference thing. But I'm not sure about putting such long passages in a bulleted list.

asmeurer and others added 16 commits October 26, 2023 13:53
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
@gabalafou
Copy link
Contributor

I just pushed 3 commits. Please be sure to review them.

@gabalafou
Copy link
Contributor

Happy to answer any questions about the changes I made

@gabalafou
Copy link
Contributor

I just now pushed one more commit to update some places I missed when moving the screenshots around.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads really well, thanks @asmeurer. And thanks for the detailed review @gabalafou. I only had two minor comments, so I'll just give this my 👍🏼 and let you two finish it off.

The SymPy Live extension in the documentation was removed, as it was
considered too much of a maintenance burden for the SymPy community to
maintain. There is a new [SymPy Live](https://live.sympy.org/) shell that
runs on [JupyterLite](https://jupyter.org/try-jupyter/lab/index.html)—that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor formatting: should there be spaces around the -?

[Pyodide](https://pyodide.org/en/stable/). We are hopeful that the
JupyterLite community can come up with an equivalent SymPy Live-like
extension that so that we can re-enable similar functionality in the SymPy
documentation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be useful to say something like "We are aware of in-progress work to do exactly this in jupyterlite-sphinx" (this is what Albert demoed in the Labs meeting last week, and it's a deliverable on the Scientific Python grant).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really familiar with that effort, but I'd love to sync with @steppi about this.

asmeurer and others added 5 commits October 31, 2023 11:59
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
asmeurer and others added 3 commits October 31, 2023 12:49
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
@bskinn bskinn merged commit ee86028 into develop Oct 31, 2023
2 checks passed
@bskinn bskinn deleted the sympy-docs branch October 31, 2023 21:48
gabalafou added a commit that referenced this pull request Nov 28, 2023
* Start post on CZI SymPy documentation work

* Write more of the sympy documentation post

* Write some more of the sympy docs blog post

* Final first draft of the sympy docs post

* Add some metadata

* Add survey results image

* Add alt text to the images

* Add some categories

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Fix link to Oscar's post

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Manually apply change from review

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Add link to codegen blog post

* Update apps/labs/posts/sympy_documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Add hero and featured images

* Fix YAML

* Remove HTML comment

* Remove HTML comment

* Use a dash in the filename

* Fix publish date

* Fix a code example

* Fix publication date

* Adjust some formatting (captions and math)

- Add italics and centering to two image captions
- Change from raw LaTeX style math markup to formatted math
- Some incidental changes from VS Code automatic MD formatting

* Some fairly heavy edits:

- Flattenned long-narrative lists (precious space is lost on mobile)
- Set the hero and featured image to the screenshot of the SymPy docs main page
- Moved the screenshots apart so that they break up the prose
- Removed the pre-Diataxis screenshot (the before/after difference wasn't
  (immediately obvious and the blog post had too many screenshots)

* remove unneeded stock feature/hero images

* remove unused screeshot

* update prose to reflect screenshots moved around

* Update apps/labs/posts/sympy-documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy-documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy-documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy-documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy-documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy-documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy-documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

* Update apps/labs/posts/sympy-documentation.md

Co-authored-by: gabalafou <gabriel@fouasnon.com>

---------

Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: Brian Skinn <brian.skinn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants