-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post on SymPy Documentation #794
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really clear and easy to follow, great job!
Most of my suggestions are about changing which text you hyperlink because I think a lot nowadays about how links show up in assistive tech. I strive to make pages so that if you pull out all of the links in a list separate from the page, the links will still mostly make sense.
3. We were been able to identify some primary areas of documentation that | ||
to prioritize for writing new documentation guides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such as? Should you list them here?
three main takeaways of the survey were: | ||
|
||
1. The main SymPy documentation site (https://docs.sympy.org) is overwhelmingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if instead of having this long form content live in the format of a list, if it would be more reader-friendly to give a shorthand version of the content in a short list and then follow into what you've written below, like so:
three main takeaways of the survey were: | |
1. The main SymPy documentation site (https://docs.sympy.org) is overwhelmingly | |
three main takeaways of the survey were: | |
1. SymPy's own documentation site is more popular than other resources such as StackOverflow. | |
2. Organization and layout needed improvement. | |
3. The community wanted new documentation areas. | |
The main SymPy documentation site (https://docs.sympy.org) is overwhelmingly |
Something like that
written that outlines a deprecation policy. This guide brings three new things | ||
to SymPy: | ||
|
||
- A clear policy on when backwards compatibility breaks should be made. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be just a personal preference thing. But I'm not sure about putting such long passages in a bulleted list.
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
I just pushed 3 commits. Please be sure to review them. |
Happy to answer any questions about the changes I made |
I just now pushed one more commit to update some places I missed when moving the screenshots around. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads really well, thanks @asmeurer. And thanks for the detailed review @gabalafou. I only had two minor comments, so I'll just give this my 👍🏼 and let you two finish it off.
The SymPy Live extension in the documentation was removed, as it was | ||
considered too much of a maintenance burden for the SymPy community to | ||
maintain. There is a new [SymPy Live](https://live.sympy.org/) shell that | ||
runs on [JupyterLite](https://jupyter.org/try-jupyter/lab/index.html)—that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor formatting: should there be spaces around the -
?
[Pyodide](https://pyodide.org/en/stable/). We are hopeful that the | ||
JupyterLite community can come up with an equivalent SymPy Live-like | ||
extension that so that we can re-enable similar functionality in the SymPy | ||
documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be useful to say something like "We are aware of in-progress work to do exactly this in jupyterlite-sphinx
" (this is what Albert demoed in the Labs meeting last week, and it's a deliverable on the Scientific Python grant).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really familiar with that effort, but I'd love to sync with @steppi about this.
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
Co-authored-by: gabalafou <gabriel@fouasnon.com>
* Start post on CZI SymPy documentation work * Write more of the sympy documentation post * Write some more of the sympy docs blog post * Final first draft of the sympy docs post * Add some metadata * Add survey results image * Add alt text to the images * Add some categories * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Fix link to Oscar's post * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Manually apply change from review * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Add link to codegen blog post * Update apps/labs/posts/sympy_documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Add hero and featured images * Fix YAML * Remove HTML comment * Remove HTML comment * Use a dash in the filename * Fix publish date * Fix a code example * Fix publication date * Adjust some formatting (captions and math) - Add italics and centering to two image captions - Change from raw LaTeX style math markup to formatted math - Some incidental changes from VS Code automatic MD formatting * Some fairly heavy edits: - Flattenned long-narrative lists (precious space is lost on mobile) - Set the hero and featured image to the screenshot of the SymPy docs main page - Moved the screenshots apart so that they break up the prose - Removed the pre-Diataxis screenshot (the before/after difference wasn't (immediately obvious and the blog post had too many screenshots) * remove unneeded stock feature/hero images * remove unused screeshot * update prose to reflect screenshots moved around * Update apps/labs/posts/sympy-documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy-documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy-documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy-documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy-documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy-documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy-documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> * Update apps/labs/posts/sympy-documentation.md Co-authored-by: gabalafou <gabriel@fouasnon.com> --------- Co-authored-by: gabalafou <gabriel@fouasnon.com> Co-authored-by: Brian Skinn <brian.skinn@gmail.com>
I still need some help here with cleaning up the formatting and the metadata. Feel free to push up changes directly to my branch.
I'd like to get this posted by the end of the month if possible so that I can reference it in our grant report to CZI.
Text styling
Non-text contents