-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused imports #142
Conversation
Many thanks @Smit-create . I will leave this one for @mmcky , who is on holidays but will be back soon. |
@Smit-create is this still relevant. Let me know and I can review + merge. Thanks. |
@Smit-create do you know what this RED text means in a GitHub diff? I haven't seen this before |
Thanks @mmcky. Sorry for the delayed response. This color is rarely seen but I read somewhere that it denotes a syntax error. I am not sure how that is coming up in a |
This is the fix: d42007d that removes the dark red background. GitHub probably thought it was a syntax error in |
thanks @Smit-create |
@Smit-create I am seeing two execution failures on the preview build that is not on the current live site https://6581b2a87b7a6f228f93f7a7--wonderful-lalande-528d1c.netlify.app/status
|
I see those are the missing cases as the snippet is loaded from Just wanted to check that why the CI didn't fail on this? |
The |
@Smit-create any luck on fixing the final two issues? |
Sure, fixing them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Smit-create
Fixes #139
This PR: