Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports #142

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Remove unused imports #142

merged 6 commits into from
Jan 15, 2024

Conversation

Smit-create
Copy link
Member

@Smit-create Smit-create commented Jul 15, 2023

Fixes #139

This PR:

  1. removes unused imports
  2. removes extra white space

@github-actions github-actions bot temporarily deployed to commit July 15, 2023 06:46 Inactive
@jstac
Copy link
Contributor

jstac commented Jul 15, 2023

Many thanks @Smit-create . I will leave this one for @mmcky , who is on holidays but will be back soon.

@mmcky
Copy link
Contributor

mmcky commented Sep 20, 2023

@Smit-create is this still relevant. Let me know and I can review + merge. Thanks.

@github-actions github-actions bot temporarily deployed to commit September 21, 2023 09:04 Inactive
@github-actions github-actions bot temporarily deployed to commit December 14, 2023 01:54 Inactive
@mmcky
Copy link
Contributor

mmcky commented Dec 19, 2023

@Smit-create do you know what this RED text means in a GitHub diff? I haven't seen this before

Screenshot 2023-12-19 at 5 18 28 pm

@mmcky mmcky added the review label Dec 19, 2023
@Smit-create
Copy link
Member Author

Thanks @mmcky. Sorry for the delayed response. This color is rarely seen but I read somewhere that it denotes a syntax error. I am not sure how that is coming up in a .md file.

@Smit-create
Copy link
Member Author

This is the fix: d42007d that removes the dark red background. GitHub probably thought it was a syntax error in md format.

@github-actions github-actions bot temporarily deployed to commit December 19, 2023 15:11 Inactive
@mmcky
Copy link
Contributor

mmcky commented Dec 19, 2023

thanks @Smit-create

@mmcky
Copy link
Contributor

mmcky commented Dec 19, 2023

@Smit-create I am seeing two execution failures on the preview build that is not on the current live site

https://6581b2a87b7a6f228f93f7a7--wonderful-lalande-528d1c.netlify.app/status

NameError: name 'float64' is not defined
NameError: name 'njit' is not defined

@Smit-create
Copy link
Member Author

I see those are the missing cases as the snippet is loaded from _static. I'll try to fix them.

Just wanted to check that why the CI didn't fail on this?

@mmcky
Copy link
Contributor

mmcky commented Dec 20, 2023

I see those are the missing cases as the snippet is loaded from _static. I'll try to fix them.

Just wanted to check that why the CI didn't fail on this?

The -n -W --keep-going is missing from ci.yml is why. 🤔

@mmcky
Copy link
Contributor

mmcky commented Jan 15, 2024

@Smit-create any luck on fixing the final two issues?

@Smit-create
Copy link
Member Author

Sure, fixing them.

@github-actions github-actions bot temporarily deployed to commit January 15, 2024 07:02 Inactive
@mmcky mmcky self-requested a review January 15, 2024 07:10
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Smit-create

@mmcky mmcky merged commit 0ad4aeb into main Jan 15, 2024
6 checks passed
@mmcky mmcky deleted the i-139 branch January 15, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files containing unused imports
3 participants