Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update quantecon-book-theme==0.6.0 #311

Merged
merged 2 commits into from
Oct 3, 2023
Merged

MAINT: Update quantecon-book-theme==0.6.0 #311

merged 2 commits into from
Oct 3, 2023

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Sep 26, 2023

This PR tests the new refactor of the quantecon-book-theme

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 8c4abc4
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/651b7cb682cfee0008fc24fd
😎 Deploy Preview https://deploy-preview-311--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

@mmcky
Copy link
Contributor Author

mmcky commented Oct 3, 2023

@AakashGfude I am getting some missing icons still on the exercise directive. Any ideas?

Screenshot 2023-10-03 at 11 52 05 am

@mmcky
Copy link
Contributor Author

mmcky commented Oct 3, 2023

@AakashGfude I am getting some missing icons still on the exercise directive. Any ideas?

Screenshot 2023-10-03 at 11 52 05 am

@AakashGfude I just updated to the PyPI release and the icon issue is fixed. Sorry to bug you unnecessarily.

@mmcky mmcky changed the title TST: Testing for new refactor of qe-book-theme MAINT: Update quantecon-book-theme==0.6.0 Oct 3, 2023
@HumphreyYang
Copy link
Collaborator

HumphreyYang commented Oct 3, 2023

Many thanks @AakashGfude and @mmcky,

This looks great! The dark mode is really cool.

I spotted some very minor corner cases that might be improved:

  1. For Pandas tables (i.e. the one in long_run_growth) lecture has dark rows that are less visible:

Screenshot 2023-10-03 at 15 45 24

  1. The import code is grey, so it looks very similar to the background color, i.e.:

Screenshot 2023-10-03 at 15 46 15

  1. Based on my observations, I think graphs are restyled under dark mode (this looks really cool!), but there are some plots that are not in the dark mode (for example, the ones in the inequality lecture)

Screenshot 2023-10-03 at 15 50 23

  1. The exercise title is slightly harder to see:
    Screenshot 2023-10-03 at 15 53 40

  2. In Eigenvalues lecture, one of the formulae with special annotations is still in black:

Screenshot 2023-10-03 at 15 57 13

Many thanks in advance.

@AakashGfude
Copy link
Member

Thanks @HumphreyYang for analysing it so nicely. I will do the fixes and create a PR.

@mmcky
Copy link
Contributor Author

mmcky commented Oct 3, 2023

thanks @HumphreyYang this is a big help.

@AakashGfude thanks for your work on this refactor. I think I will make the switch to quantecon-book-theme==0.6.0 across all the lecture sites.

@mmcky mmcky merged commit 7a48f86 into main Oct 3, 2023
4 checks passed
@mmcky mmcky deleted the test-qe-book-theme branch October 3, 2023 22:55
@AakashGfude
Copy link
Member

Thanks @mmcky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants