-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[heavy_tails] update axis labels #319
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The following links result in the failure of the link checker (cc @mmcky ):
|
@HengchengZhang would you have time to review these links? |
@jstac the link checker is failing to pass. Otherwise this PR is building OK re: previews and html. Please go ahead when you're ready. |
lectures/heavy_tails.md
Outdated
ax.legend() | ||
|
||
|
||
ax.set_xlabel("log value") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shlff , from this display it looks like the xlabel on 523 comes after ax.legend()
. Don't you want it to be on line 520 and indented the same as ylabel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jstac .
There are three stacked plots aligned by the same x-axis. With the above code I intended to keep only the x-axis label for the bottom plot to avoid repetition.
However, to add more clarity, I think it might be better to change it back. Please find the commit below.
Many thanks @shlff , much appreciated! |
Hi @jstac this PR updates axis labels in the heavy_tails lecture.