Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[heavy_tails] update axis labels #319

Merged
merged 2 commits into from
Nov 17, 2023
Merged

[heavy_tails] update axis labels #319

merged 2 commits into from
Nov 17, 2023

Conversation

shlff
Copy link
Member

@shlff shlff commented Nov 16, 2023

Hi @jstac this PR updates axis labels in the heavy_tails lecture.

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 085d94c
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/6557228fd997410008648af3
😎 Deploy Preview https://deploy-preview-319--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shlff shlff added the in-work label Nov 16, 2023
Copy link

github-actions bot commented Nov 16, 2023

@mmcky
Copy link
Contributor

mmcky commented Nov 16, 2023

@mmcky
Copy link
Contributor

mmcky commented Nov 16, 2023

@jstac the link checker is failing to pass. Otherwise this PR is building OK re: previews and html.

Please go ahead when you're ready.

ax.legend()


ax.set_xlabel("log value")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shlff , from this display it looks like the xlabel on 523 comes after ax.legend(). Don't you want it to be on line 520 and indented the same as ylabel?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jstac .

There are three stacked plots aligned by the same x-axis. With the above code I intended to keep only the x-axis label for the bottom plot to avoid repetition.

However, to add more clarity, I think it might be better to change it back. Please find the commit below.

@jstac
Copy link
Contributor

jstac commented Nov 17, 2023

Thanks @shlff and @mmcky .

@shlff , could you please check my comment above? It might just be a problem with GitHub's code display.

@shlff
Copy link
Member Author

shlff commented Nov 17, 2023

Thanks @shlff and @mmcky .

@shlff , could you please check my comment above? It might just be a problem with GitHub's code display.

Thanks @jstac . I fixed the indentation problem, and now the x labels should appear in the correct place in the newest preview.

Thanks @mmcky for looking at the issue of the link checker.

@jstac
Copy link
Contributor

jstac commented Nov 17, 2023

Many thanks @shlff , much appreciated!

@jstac jstac merged commit f243881 into main Nov 17, 2023
4 checks passed
@jstac jstac deleted the ht_labels branch November 17, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants