Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mle] update units and labels #321

Merged
merged 1 commit into from
Nov 17, 2023
Merged

[mle] update units and labels #321

merged 1 commit into from
Nov 17, 2023

Conversation

shlff
Copy link
Member

@shlff shlff commented Nov 17, 2023

Hi @jstac this PR adds the unit in the legend and labels to the first plot of the mle lecture.

I suggest that we can either fix the labels in the following plots in this PR or create an issue to remind us to do that.

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 3c3ae7d
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/65570bbab7188200083210e2
😎 Deploy Preview https://deploy-preview-321--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@jstac
Copy link
Contributor

jstac commented Nov 17, 2023

Thanks @shlff

I suggest that we can either fix the labels in the following plots in this PR or create an issue to remind us to do that.

Please create an issue. Once you acknowledge I'll merge this PR.

@shlff shlff mentioned this pull request Nov 17, 2023
@shlff
Copy link
Member Author

shlff commented Nov 17, 2023

Thanks @shlff

I suggest that we can either fix the labels in the following plots in this PR or create an issue to remind us to do that.

Please create an issue. Once you acknowledge I'll merge this PR.

Thanks @jstac . I created such an issue #322 .

@jstac
Copy link
Contributor

jstac commented Nov 17, 2023

Great, thanks @shlff , much appreciated.

@jstac jstac merged commit 7274f15 into main Nov 17, 2023
5 checks passed
@jstac jstac deleted the mle_units branch November 17, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants