[cons_smooth] Update consumption smoothing lecture #376
Conversation
longye-tian
commented
Feb 19, 2024
longye-tian
commented
- Change ‘quantecon’ to ‘QuantEcon’
- Change ‘creat_cs_’ to ‘create_consumption_smoothing_’
- Fix the typo in equation in Step 2 and Third equation in 11.4.5
- unbold want, pair, many, should, smoother, permanent, as they are not defintions
- Give explanation in the parameters in the Analysis section
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -147,11 +147,11 @@ We create a Python **namedtuple** to store these parameters with default values. | |||
| ConsumptionSmoothing = namedtuple("ConsumptionSmoothing", | |||
| ["R", "g1", "g2", "β_seq", "T"]) | |||
|
|
|||
| def creat_cs_model(R=1.05, g1=1, g2=1/2, T=65): | |||
| def create_consumption_smoothing_model(R=1.05, g1=1, g2=1/2, T=65): | |||
There was a problem hiding this comment.
thanks @longye-tian.
The build is failing and I suspect the calling location needs to be updated to this new function name as well.
NameError: name 'creat_cs_model' is not definedThere was a problem hiding this comment.
Thank you @mmcky !
I just changed the function name at the calling location. :)
There was a problem hiding this comment.
thanks @longye-tian -- you will see the preview is now generating. 👍
There was a problem hiding this comment.
So glad to contribute !!
mmcky
changed the title
Change the function name at the calling location
lectures/cons_smooth.md
Outdated
|
|
||
| * $R \geq 1$ be a fixed gross one period rate of return on financial assets | ||
| * $R \geq 1$ be a fixed gross one period rate of return on financial assets. This represents the interest rate at which the consumer can borrow or lend. It determines the tradeoff between consuming today vs in the future. |
There was a problem hiding this comment.
| * $R \geq 1$ be a fixed gross one period rate of return on financial assets. This represents the interest rate at which the consumer can borrow or lend. It determines the tradeoff between consuming today vs in the future. | |
| * $R \geq 1$ be a fixed gross one period rate of return on financial assets. This represents the interest rate at which the consumer can borrow or lend. It determines the tradeoff between consuming today versus in the future. |
@jstac would we usually use versus (in full) rather than vs in a sentence. Is that correct?
| @@ -83,7 +83,7 @@ We require it to satisfy two **boundary conditions**: | |||
|
|
|||
| The **terminal condition** $a_{T+1} \geq 0$ requires that the consumer not leave the model in debt. | |||
|
|
|||
| (We'll soon see that a utility maximizing consumer won't **want** to die leaving positive assets, so she'll arrange her affairs to make | |||
| (We'll soon see that a utility maximizing consumer won't want to die leaving positive assets, so she'll arrange her affairs to make | |||
There was a problem hiding this comment.
@longye-tian perhaps we can use a note admonition rather than brackets
```{note}
<text>
```
|
@jstac I have now reviewed this PR and made some comments above. |
|
@longye-tian Many thanks for your contribution! This is very very helpful and there are lots of good changes. Just one thing that's a problem: We generally prefer to do our own writing. So if you feel we should add something like "This is also a decision variable, representing how much the consumer chooses to consume each period out of their income and financial wealth.", then it's better to put it in an issue (open an issue in the issue tracker suggesting some new sentences), and leave it to us to decide whether we want to take some of that suggestion. That's why I said this PR should only include noncontroversial additions, like fixes to the code or quantecon -> QuantEcon. Would you mind to remove all the new sentences from this PR? Then, in an issue, you might like to tell us where you think we need more explanation or discussion, including these new sentences. |
Remove all new sentences
|
Perfect, thanks @longye-tian. Nice work :-) |
