Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to markov_chain_II #395

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Improvements to markov_chain_II #395

merged 3 commits into from
Mar 11, 2024

Conversation

jstac
Copy link
Contributor

@jstac jstac commented Mar 11, 2024

Misc improvements to the lecture.

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit e0f0381
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/65ef91568e86df00075fd8f0
😎 Deploy Preview https://deploy-preview-395--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jstac
Copy link
Contributor Author

jstac commented Mar 11, 2024

@mmcky , would you mind to look at this? I'm not sure why it's failing.

The "missing" reference mc_po_conv_thm is present in another lecture (markov_chains_I).

@mmcky
Copy link
Contributor

mmcky commented Mar 11, 2024

@jstac this should be fixed with the latest commit. Essentially sphinx-proof objects belong to the prf domain so you need to use {prf:ref} to reference them (https://sphinx-proof.readthedocs.io/en/latest/syntax.html#theorems).

https://manual.quantecon.org/styleguide/admonitions.html#proofs

It is a little confusing as sphinx-exercise uses global labels

Copy link

github-actions bot commented Mar 11, 2024

@github-actions github-actions bot temporarily deployed to pull request March 11, 2024 22:38 Inactive
@jstac
Copy link
Contributor Author

jstac commented Mar 11, 2024

Thanks @mmcky .

@github-actions github-actions bot temporarily deployed to pull request March 11, 2024 23:27 Inactive
@jstac jstac merged commit 5f2a847 into main Mar 11, 2024
6 checks passed
@jstac jstac deleted the update_ergo branch March 11, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants