-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[monte_carlo] updates and editorial suggestions #417
Conversation
Revised under Editorial suggestion #414
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -136,12 +136,12 @@ But fortunately there's an easy way to do this, at least approximately. | |||
This is the Monte Carlo method, which runs as follows: | |||
|
|||
1. Generate $n$ independent draws of $X_1$, $X_2$ and $X_3$ on a computer, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Generate $n$ independent draws of $X_1$, $X_2$ and $X_3$ on a computer, | |
1. generate $n$ independent draws of $X_1$, $X_2$ and $X_3$ on a computer, |
default_μ = 0.0001 | ||
default_ρ = 0.1 | ||
default_ν = 0.001 | ||
default_S0 = 10 | ||
default_h0 = 0 | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@longye-tian I wonder if this would be better setup as a named tuple
called defaults
so that would then be referenced as defaults.μ
as a tidier solution.
thanks @longye-tian just had some questions re: variable choice. |
Many thanks @longye-tian and thanks @mmcky for the review. @mmcky 's suggestions are good but time is short so let's go ahead and merge this. |
Related to Editorial suggestion #414, in particular,
Code
default_param
(i.e.default_μ
).Content