Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[markov_chain_I] Hamilton's chain animation #457

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

longye-tian
Copy link
Collaborator

Hi Matt @mmcky,

This pull request includes the animation (#456 ) for the convergence to a stationary distribution in our Markov Chain lecture (markov_chain_I, Hamilton's chain).

Thank you for the help testing the animation :))

Best regards,
Longye

This pull request include the animation for the convergence to a stationary distribution in our Markov Chain lecture (markov_chain_I, Hamilton's chain).
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 26c0eb7
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/666664792fa30e00089094b6
😎 Deploy Preview https://deploy-preview-457--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@longye-tian longye-tian requested review from mmcky and jstac June 10, 2024 02:27
Copy link

github-actions bot commented Jun 10, 2024

@github-actions github-actions bot temporarily deployed to pull request June 10, 2024 02:35 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 10, 2024 02:36 Inactive
@mmcky
Copy link
Contributor

mmcky commented Jun 17, 2024

thanks @longye-tian this is looking great. It works out of the box for html output.

For pdf it doesn't break the build and leaves the following text representation
Screenshot 2024-06-17 at 3 22 00 PM

I think a link back to the website would be a better option and will require an update to the sphinx-jupyterbook-latex package to insert a link for these javascript object types.

@jstac using this specific package for animated outputs works well. I am comfortable with proceeding based on the fact it doesn't impact PDF output generation, and in the medium term we can improve the representation in the pdf output.

@mmcky mmcky changed the title DRAFT: [markov_chain_I] Hamilton's chain animation [markov_chain_I] Hamilton's chain animation Jun 17, 2024
@jstac
Copy link
Contributor

jstac commented Jun 17, 2024

Thanks @mmcky , I'll leave this with you.

@mmcky
Copy link
Contributor

mmcky commented Jun 17, 2024

thanks @longye-tian. I am excited to see some animations working their way into the lectures. The way this is done is nicely compatible with jupyter-book out of the box and I will work to enhance the pdf representation. Let's get this merged.

@mmcky mmcky merged commit 6fbd7d1 into main Jun 17, 2024
8 checks passed
@mmcky mmcky deleted the markov_chain_I_animation branch June 17, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants