-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lp_intro] update suggestions #474
Conversation
This pull request update some of the the lp_intro.md lecture according to #469 (mainly involving typos, styles) In particular, the changes include: - [x] Unbold non-definition words and use italics for emphases - [x] Remove capitalization in the titles - [x] Add period for the first sentence in example 1 - [x] use "`ortools.linear_solver`" - [x] "... using it's status" -> "... using its status" - Round the print in the format string for printing. - "three year" -> "three-year" - "Let's us" -> "Let's" - "LP" -> "Linear programming" - In the dot point in the "useful transformations" section, remove the capitalization of the second word. - 'bounds' -> `bounds` - We did not discuss complementary slackness, so we can delete it. One thing I find is that the column header is automatically in bold, so I cannot fix it by changing the md file.
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Many thanks @longye-tian , this is much appreciated. @mmcky , can you please review? |
thanks @longye-tian
Is this in some code output? Or a part of the document? |
Hi Matt @mmcky , It is part of the markdown table, for example in the lp_intro.md, we have the following table,
The default setting in the md table is that the column header is in bold. I wish to unbold the column header as according to our style guide, the bold font is for definition. Do you know how to do that? Thank you Matt! Best, |
Thanks for explaining this @longye-tian. If this is part of the table rendering then that would be controlled by the theme. @jstac would you like all table headers to be not bolded? It is common for them to be bolded but if that interferes with usage from our style guide then we should be able to update the style. |
@mmcky @longye-tian Let's go with the default theme for marking up tables. It's best to stick with defaults when possible. Thanks again @longye-tian and thanks @mmcky for the review. Merging. |
Dear John @jstac,
I have updated some of the lp_intro.md lecture according to #469 (mainly involving typos, and styles)
In particular, the changes include:
Code
Typos and styles
ortools.linear_solver
"bounds
One thing I find is that the column header is automatically in bold, so I cannot fix it by changing the MD file.
For the suggestions related to materials, I will create a separate issue tracker and pull request.
Best ❤️
Longye