-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prob_dist] Update suggestions #519
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @longye-tian.
I think we should use lower case for the text titles on the x and y axis. CDF
and PDF
are acronyms so I think they should remain capitalised but I will confirm with @jstac
Co-authored-by: Matt McKay <mmcky@users.noreply.github.com>
Hi Matt, Thanks! Just updated the labels to lowercase letters except the PMF, CDF, PDF and KDE. Best, |
thanks @longye-tian. @jstac this is ready for your final review. It is my understanding that acronyms like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @longye-tian
thanks @longye-tian for these updates. I will merge this now. |
Dear John @jstac ,
This pull request update prob_dist.md according to #402 .
In particular, this pull request
Best ❤️
Longye