Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Observations from lecture-python-intro #227

Closed
mmcky opened this issue Oct 3, 2023 · 0 comments · Fixed by #228
Closed

Theme Observations from lecture-python-intro #227

mmcky opened this issue Oct 3, 2023 · 0 comments · Fixed by #228
Assignees

Comments

@mmcky
Copy link
Contributor

mmcky commented Oct 3, 2023

          Many thanks @AakashGfude and @mmcky,

This looks great! The dark mode is really cool.

I spotted some very minor corner cases that might be improved:

  1. For Pandas tables (i.e. the one in long_run_growth) lecture has dark rows that are less visible:

Screenshot 2023-10-03 at 15 45 24

  1. The import code is grey, so it looks very similar to the background color, i.e.:

Screenshot 2023-10-03 at 15 46 15

  1. Based on my observations, I think graphs are restyled under dark mode (this looks really cool!), but there are some plots that are not in the dark mode (for example, the ones in the inequality lecture)

Screenshot 2023-10-03 at 15 50 23

  1. The exercise title is slightly harder to see:
    Screenshot 2023-10-03 at 15 53 40

  2. In Eigenvalues lecture, one of the formulae with special annotations is still in black:

Screenshot 2023-10-03 at 15 57 13

Many thanks in advance.

Originally posted by @HumphreyYang in QuantEcon/lecture-python-intro#311 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants