Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers have hardcoded Quantecon stuff #53

Open
AakashGfude opened this issue Oct 21, 2020 · 1 comment
Open

Headers have hardcoded Quantecon stuff #53

AakashGfude opened this issue Oct 21, 2020 · 1 comment
Assignees
@DrDrij @AakashGfude
Labels
enhancement New feature or request

Comments

@AakashGfude
Copy link
Member

The header at present in quantecon-book theme has Quantecon text and link hardcoded, which needs to be adjusted with variables like html_title and logo_url.

Screen Shot 2020-10-21 at 9 04 00 pm
@AakashGfude AakashGfude added the enhancement New feature or request label Oct 21, 2020
@AakashGfude AakashGfude mentioned this issue Oct 21, 2020
Merged
@AakashGfude
Copy link
Member Author

Actually this QuantEcon is coming from a css rule. which uses the image url for this logo as one of the properties.
https://github.com/QuantEcon/quantecon-book-theme/blob/master/quantecon_book_theme/scss/quantecon-book-theme.scss#L348

we might need to remove this hardcoding.
cc: @DrDrij

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DrDrij DrDrij

@AakashGfude AakashGfude

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DrDrij @AakashGfude