Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Checking mathjax version and functioning accordingly #150

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

AakashGfude
Copy link
Member

Decoding mathjax version based on mathjax_path config variable, and using the hardcoded mathjax configuration only for version 3. Which will be removed at a later stage #138

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #150 (c75de5a) into master (13d5f7a) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   72.29%   72.22%   -0.08%     
==========================================
  Files           2        2              
  Lines         231      234       +3     
==========================================
+ Hits          167      169       +2     
- Misses         64       65       +1     
Flag Coverage Δ
pytests 72.22% <66.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
quantecon_book_theme/__init__.py 61.48% <66.66%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d5f7a...c75de5a. Read the comment docs.

@mmcky
Copy link
Contributor

mmcky commented Jun 16, 2021

thanks @AakashGfude this seems like a sensible way forward for mathjax compatibility.

Should we add the macro's for v2 as well using the Mathjax.Hub api?

@AakashGfude
Copy link
Member Author

thanks @AakashGfude this seems like a sensible way forward for mathjax compatibility.

Should we add the macro's for v2 as well using the Mathjax.Hub api?

@mmcky I was thinking since we can use the config variable to define it mathjax_config in _config.yml. We should just define the v2 configs there?

@mmcky mmcky merged commit 4e0e255 into master Jun 18, 2021
@mmcky mmcky deleted the mathjax-version-conditional branch June 18, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants