Drop Python<3.9 according to NEP29 (#307)

* Drop Python<3.9 according to NEP29 * Changelog * Adapt CI config * Fix flake8 hook * Add osx_64_python3.11_default.____cpython variant
Quantco · Oct 9, 2023 · f12573b · f12573b
1 parent ec62c41
commit f12573b
Show file tree

Hide file tree

Showing 13 changed files with 13 additions and 97 deletions.
diff --git a/.ci_support/linux_64_python3.7_default.____cpython.yaml b/.ci_support/linux_64_python3.7_default.____cpython.yaml
diff --git a/.ci_support/linux_64_python3.8_default.____cpython.yaml b/.ci_support/linux_64_python3.8_default.____cpython.yaml
diff --git a/...osx_64_python3.7_default.____cpython.yaml → ...sx_64_python3.11_default.____cpython.yaml b/...osx_64_python3.7_default.____cpython.yaml → ...sx_64_python3.11_default.____cpython.yaml
@@ -11,8 +11,9 @@ cxx_compiler_version:
 macos_machine:
 - x86_64-apple-darwin13.4.0
 numpy:
-- '1.17'
+- '1.23'
 python:
-- 3.7.* *_cpython
+- 3.11.* *_cpython
 target_platform:
 - osx-64
+
diff --git a/.ci_support/osx_64_python3.8_default.____cpython.yaml b/.ci_support/osx_64_python3.8_default.____cpython.yaml
diff --git a/.ci_support/osx_arm64_python3.8.____cpython.yaml b/.ci_support/osx_arm64_python3.8.____cpython.yaml
diff --git a/.ci_support/win_64_python3.7.____cpython.yaml b/.ci_support/win_64_python3.7.____cpython.yaml
diff --git a/.ci_support/win_64_python3.8.____cpython.yaml b/.ci_support/win_64_python3.8.____cpython.yaml
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,14 +29,10 @@ jobs:
       fail-fast: true
       matrix:
         include:
-          - { os: ubuntu-latest, python-version: '3.7' }
-          - { os: ubuntu-latest, python-version: '3.8' }
           - { os: ubuntu-latest, python-version: '3.9' }
           - { os: ubuntu-latest, python-version: '3.10' }
           - { os: ubuntu-latest, python-version: '3.11' }
-          - { os: macos-latest, python-version: '3.7' }
           - { os: macos-latest, python-version: '3.11' }
-          - { os: windows-latest, python-version: '3.7' }
           - { os: windows-latest, python-version: '3.11' }
     steps:
       - name: Checkout branch

diff --git a/.github/workflows/conda-build.yml b/.github/workflows/conda-build.yml
@@ -15,14 +15,11 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - { conda_build_yml: linux_64_python3.7_default.____cpython,       os: ubuntu-latest,  conda-build-args: '' }
-          - { conda_build_yml: linux_64_python3.8_default.____cpython,       os: ubuntu-latest,  conda-build-args: '' }
           - { conda_build_yml: linux_64_python3.9_default.____cpython,       os: ubuntu-latest,  conda-build-args: '' }
           - { conda_build_yml: linux_64_python3.10_default.____cpython,      os: ubuntu-latest,  conda-build-args: '' }
           - { conda_build_yml: linux_aarch64_python3.10_default.____cpython, os: ubuntu-latest,  conda-build-args: ' --no-test' }
           - { conda_build_yml: linux_ppc64le_python3.10_default.____cpython, os: ubuntu-latest,  conda-build-args: ' --no-test' }
-          - { conda_build_yml: osx_64_python3.7_default.____cpython,         os: macos-latest,   conda-build-args: '' }
-          - { conda_build_yml: osx_64_python3.8_default.____cpython,         os: macos-latest,   conda-build-args: '' }
+          - { conda_build_yml: osx_64_python3.11_default.____cpython,         os: macos-latest,   conda-build-args: '' }
           - { conda_build_yml: osx_arm64_python3.9.____cpython,              os: macos-latest,   conda-build-args: ' --no-test' }
           - { conda_build_yml: osx_arm64_python3.10.____cpython,             os: macos-latest,   conda-build-args: ' --no-test' }
           - { conda_build_yml: win_64_python3.9.____cpython,                 os: windows-latest, conda-build-args: '' }

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -6,7 +6,7 @@ repos:
        additional_dependencies: [flake8-docstrings, flake8-rst-docstrings]
        args:
          - --safe
-         - --target-version=py36
+         - --target-version=py39
  - repo: https://github.com/Quantco/pre-commit-mirrors-flake8
    rev: 6.1.0
    hooks:
@@ -20,6 +20,7 @@ repos:
           flake8-docstrings=1.6.0,
           flake8-print=4.0.0,
           pep8-naming=0.11.1,
+          python<3.12,
         ]
  - repo: https://github.com/Quantco/pre-commit-mirrors-isort
    rev: 5.12.0
@@ -31,7 +32,7 @@ repos:
    hooks:
     - id: mypy-conda
       additional_dependencies:
-       - python=3.8
+       - python=3.9
  - repo: https://github.com/Quantco/pre-commit-mirrors-pyupgrade
    rev: 3.13.0
    hooks:

diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -13,6 +13,7 @@ Unreleased
 **Other changes:**
 
 - Improve the performance of ``from_pandas`` in the case of low-cardinality categorical variables.
+- Require Python>=3.9 in line with `NEP 29 <https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table>`_
 
 3.1.10 - 2023-06-23
 -------------------

diff --git a/pyproject.toml b/pyproject.toml
@@ -34,7 +34,10 @@ skip = [
   "*-manylinux_i686",
   "pp*", 
   "*-musllinux_*",
-  "cp312*"
+  "cp312*",
+  "cp36*",
+  "cp37*",
+  "cp38*",
 ]
 test-requires = ["pytest", "pytest-xdist"]
 test-command = "pytest {package}/tests/test_matrices.py"

diff --git a/setup.py b/setup.py
@@ -159,6 +159,7 @@
     package_dir={"": "src"},
     packages=find_packages(where="src"),
     install_requires=["numpy", "pandas", "scipy"],
+    python_requires=">=3.9",
     ext_modules=cythonize(
         ext_modules,
         annotate=False,