Adjust tests to new formulaic behavior #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanmart
requested review from
MarcAntoineSchmidtQC,
xhochy,
jtilly and
lbittarello
as code owners
jtilly
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #418.
Formulaic #220 introduced a change in the names for categorical columns: instead of a common
{column}[T.{category}]format, formulaic now only uses the latter for treatment-encoded variables (i.e.,ensure_full_rank=True), and uses our default ({column}[{category}]) for the rest.As we have a different default behavior anyways, I don't think we want to follow this change, so I just removed the test (otherwise either the nightlies or the non-nightlies will fail). Furthermore, our implementation does not currently allow for different categorical variables having different formats, so there is one test case which would be impossible to satisfy anyways. We already have a number of other test to make sure that the categorical names we create match our expectations, IMO those should suffice.
Checklist
CHANGELOG.rstentry