Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formulaic reference #425

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Fix formulaic reference #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea6704f
update Structured
MarcAntoineSchmidtQC Dec 5, 2024
d345a21
Merge remote-tracking branch 'origin/main' into fix-formulaic-reference
MarcAntoineSchmidtQC Dec 5, 2024
e55cd3b
update codeowners
MarcAntoineSchmidtQC Dec 5, 2024
eb3c209
Merge remote-tracking branch 'origin/main' into fix-formulaic-reference
MarcAntoineSchmidtQC Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @MarcAntoineSchmidtQC @xhochy @jtilly @lbittarello
* @MarcAntoineSchmidtQC @jtilly @lbittarello @stanmart
7 changes: 6 additions & 1 deletion tests/test_formula.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
from formulaic.parser.types import Factor
from scipy import sparse as sps

try:
from formulaic.utils.structured import Structured
except ImportError:
from formulaic.parser.types import Structured

import tabmat as tm
from tabmat.formula import (
TabmatMaterializer,
Expand Down Expand Up @@ -1145,5 +1150,5 @@ def test_model_spec_pickleable(self, materializer):
pickle.dump(ms.model_spec, o)
o.seek(0)
ms2 = pickle.load(o)
assert isinstance(ms, formulaic.parser.types.Structured)
assert isinstance(ms, Structured)
assert ms2.lhs.formula.root == ["a"]
Loading