Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller #146

Closed
wants to merge 95 commits into from
Closed

Controller #146

wants to merge 95 commits into from

Conversation

ba2tro
Copy link
Member

@ba2tro ba2tro commented Aug 13, 2024

Based on #120, first draft for some control plane examples

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 64.00000% with 63 lines in your changes missing coverage. Please review.

Project coverage is 71.56%. Comparing base (29d78f8) to head (d763921).
Report is 2 commits behind head on master.

Files Patch % Lines
src/ProtocolZoo/controllers.jl 24.00% 19 Missing ⚠️
src/ProtocolZoo/cutoff.jl 42.42% 19 Missing ⚠️
src/ProtocolZoo/ProtocolZoo.jl 74.62% 17 Missing ⚠️
src/ProtocolZoo/swapping.jl 90.24% 4 Missing ⚠️
src/queries.jl 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   72.94%   71.56%   -1.39%     
==========================================
  Files          39       42       +3     
  Lines        1693     1811     +118     
==========================================
+ Hits         1235     1296      +61     
- Misses        458      515      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ba2tro ba2tro requested a review from Krastanov August 15, 2024 22:02
@ba2tro
Copy link
Member Author

ba2tro commented Sep 23, 2024

This branch got messed up while merging master, so closing this in favor of #157

@ba2tro ba2tro closed this Sep 23, 2024
@ba2tro ba2tro deleted the controller branch November 8, 2024 20:28
@ba2tro ba2tro restored the controller branch November 8, 2024 20:34
@ba2tro ba2tro deleted the controller branch November 8, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants