Replace line-feed with comma plus space in message #41
Conversation
qubesusbproxy/core3ext.py
Outdated
| @@ -642,9 +642,10 @@ async def on_device_attach_usb(self, vm, event, device, options): | |||
| else: | |||
| # TODO: sanitize and include stdout | |||
| sanitized_stderr = ''.join( | |||
| [chr(c) for c in e.stderr if 0x20 <= c < 0x80]) | |||
| [chr(c) for c in e.stderr if 0x20 <= c < 0x80 | |||
| or c in [0x0A, 0x0D]]) | |||
There was a problem hiding this comment.
I don't think simply allowing newlines in an exception message is a good idea. Depending on what applications will do with that, it may mess with formatting, or even allow injecting something. This is especially important since it's about a message received from a VM - that's why it's sanitized after all.
Maybe better to replace disallowed chars with something (we use "_" for that in several places) instead of just removing them? Or replace newline specifically with a coma?
There was a problem hiding this comment.
Or replace newline specifically with a coma?
Very well said. But coma+space (or semicolon+space.). Amendment will follow shortly.
alimirjamali
force-pushed
the
Issue-5701
branch
3 times, most recently
from
866047e
to
9264727
Compare
alimirjamali
changed the title
|
@marmarek This is fixed as advised. The last force-push was to change the commit message |
alimirjamali
force-pushed
the
Issue-5701
branch
from
9264727
to
7daba26
Compare
resolves: QubesOS/qubes-issues#5701