Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interrupt handling and send signal to current loop #149

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

fepitre
Copy link
Member

@fepitre fepitre commented Aug 20, 2024

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.17%. Comparing base (234bd95) to head (d7c3ee9).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
qubesbuilder/cli/cli_base.py 47.61% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   78.72%   77.17%   -1.56%     
==========================================
  Files          47       47              
  Lines        5353     5366      +13     
==========================================
- Hits         4214     4141      -73     
- Misses       1139     1225      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fepitre
Copy link
Member Author

fepitre commented Sep 3, 2024

@marmarek can you merge it not too late, I've several rogue dispvms on runner...

@marmarek marmarek merged commit e1bdbcd into QubesOS:main Sep 3, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

builderv2: aborting build with ctrl-c does not cleaup the env
2 participants