-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove too strict checking for kernel on startup #634
Conversation
Nowadays empty kernel is automatically converted to pvgrub2, so don't refuse that value. Fixes: ba8bc65 "Allow setting "none" kernel to use in-vm kernel in any virt_mode" QubesOS/qubes-issues#5212
"None" kernel gets translated to appropriate grub variant according to virt_mode. QubesOS/qubes-issues#5212
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 69.31% 69.32% +0.01%
==========================================
Files 58 58
Lines 11994 11992 -2
==========================================
Hits 8314 8314
+ Misses 3680 3678 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111405-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests5 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 201 fixed
Unstable tests
|
Nowadays empty kernel is automatically converted to pvgrub2, so don't
refuse that value.
Fixes: ba8bc65 "Allow setting "none" kernel to use in-vm kernel in any
virt_mode"
QubesOS/qubes-issues#5212