-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Qubes OS Update reporting for dom0 #213
Conversation
pylint complains and it seems its correct. I know the old version didn't use |
Now that I look again, I see that no update error handling is done for the actual update. I will tend to that as well. It was mentioned in another issue. |
Ok. It is done. I added an additional check for the actual One user had referred to this bug in the Github Issues (I can not find the exact issue). Where if the actual updates fails (e.g. due to network problem or a dnf conflict or anything else), the GUI shows the green check mark. |
Pylint fails due to curl error during downloading metadata for dnf. What is wrong here? |
PipelineRetryFailed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 93.56% 93.72% +0.16%
==========================================
Files 57 57
Lines 10823 10843 +20
==========================================
+ Hits 10126 10163 +37
+ Misses 697 680 -17 ☔ View full report in Codecov by Sentry. |
Ok review bot. I will extend the |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024071910-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070519-4.3&flavor=update
Failed tests9 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/105374#dependencies 5 fixed
Unstable tests
|
fixes: QubesOS/qubes-issues#9355