Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-pci updated to new devices API miss entries in "used by" column #9354

Closed
marmarek opened this issue Jul 14, 2024 · 1 comment · Fixed by QubesOS/qubes-core-admin-client#299
Assignees
Labels
affects-4.3 This issue affects Qubes OS 4.3. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@marmarek
Copy link
Member

How to file a helpful issue

Qubes OS release

R4.3

Brief summary

Column "used by" doesn't always include qube to which device is assigned

Steps to reproduce

  1. Create sys-usb on a system with multiple usb controllers
  2. Observe qvm-pci ls or qvm-pci ls sys-usb output

Expected behavior

All USB controllers assigned to sys-usb gets sys-usb listed in "used by" column.

Actual behavior

Only some controllers gets the "used by" entry.
In my case I tested it with test-sys-usb:

$ qvm-pci ls test-sys-usb
BACKEND:DEVID  DESCRIPTION                                                                           USED BY
dom0:00_0d.0   USB controller: Intel Corporation Tiger Lake-LP Thunderbolt 4 USB Controller          
dom0:00_0d.2   USB controller: Intel Corporation Tiger Lake-LP Thunderbolt 4 NHI #0                  
dom0:00_0d.3   USB controller: Intel Corporation Tiger Lake-LP Thunderbolt 4 NHI #1                  sys-usb (no-strict-reset=True, permissive=True), test-sys-usb (no-strict-reset=True)
dom0:00_14.0   USB controller: Intel Corporation Tiger Lake-LP USB 3.2 Gen 2x1 xHCI Host Controller  

It isn't better when listing all devices.

Relevant part of qubes.xml:

      <devices class="pci">
        <device backend-domain="dom0" id="00_0d.0" required="yes">
          <option name="no-strict-reset">True</option>
        </device>
        <device backend-domain="dom0" id="00_0d.2" required="yes">
          <option name="no-strict-reset">True</option>
        </device>
        <device backend-domain="dom0" id="00_0d.3" required="yes">
          <option name="no-strict-reset">True</option>
        </device>
        <device backend-domain="dom0" id="00_14.0" required="yes">
          <option name="no-strict-reset">True</option>
        </device>
      </devices>
@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. affects-4.3 This issue affects Qubes OS 4.3. labels Jul 14, 2024
@marmarek
Copy link
Member Author

@piotrbartman

@marmarek marmarek moved this to Ready in Current team tasks Jul 14, 2024
@andrewdavidwong andrewdavidwong added the needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. label Jul 14, 2024
@piotrbartman piotrbartman self-assigned this Jul 15, 2024
@piotrbartman piotrbartman moved this from Ready to In progress in Current team tasks Jul 15, 2024
@piotrbartman piotrbartman moved this from In progress to In review in Current team tasks Jul 16, 2024
marmarek added a commit to QubesOS/qubes-core-admin-client that referenced this issue Jul 18, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Current team tasks Jul 18, 2024
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.3 This issue affects Qubes OS 4.3. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants