Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies of qubes-desktop-linux-manager not stated. #9359

Open
unman opened this issue Jul 18, 2024 · 4 comments
Open

Dependencies of qubes-desktop-linux-manager not stated. #9359

unman opened this issue Jul 18, 2024 · 4 comments
Assignees
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: manager/widget good first issue This is a recommended issue for first-time contributors. needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@unman
Copy link
Member

unman commented Jul 18, 2024

How to file a helpful issue

Qubes OS release

4.2

Brief summary

From XMachina via Forum:
"Currently, the icons for the domains widgets is provided by the package xfce4-settings. I have tested this by installing and uninstalling this package and its dependencies recursively, and it is definitely this package. (Side note: I'd wager this is why these icons aren't on i3 [https://github.com//issues/7754].) The icons need to be provided in a different package and included or required by qubes-desktop-linux-manager.
The same applies for the package python3-gobject providing the individual progressbar/x/check for the Qubes Updater GUI."

Steps to reproduce

Install another DE - remove the xfce4-settings package - note that domains widget icons are no longer available.
Remove package python3-gobject - note that progress bar is not available in Updater GUI

Expected behavior

Necessary packages will be stated as dependencies

Actual behavior

Necessary packages are not stated as dependencies of qubes-desktop-linux-manager, and can be removed at will.
Possible related to #7754 for i3 WM

@unman unman added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Jul 18, 2024
@andrewdavidwong andrewdavidwong added C: manager/widget needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. affects-4.2 This issue affects Qubes OS 4.2. labels Jul 21, 2024
@marmarta marmarta added the good first issue This is a recommended issue for first-time contributors. label Oct 2, 2024
@FaithKovi
Copy link

Hello @marmarta I want to work on this.

@FaithKovi
Copy link

hello @andrewdavidwong , I am new to the project and would need some guidance with more information on how to make this first contribution.

@ben-grande
Copy link

@FaithKovi

  1. Read the code section from the docs
  2. Identify the RPM spec of qubes-desktop-linux-manager in the repository
  3. Follow the first post on steps to reproduce the issue and add the missing dependencies to the RPM spec
  4. Create a branch, commit linking this issue in the body of the commit, push to your repo, open PR against the qubes repo that holds the qubes-desktop-linux-manager package

@FaithKovi
Copy link

Thank you @ben-grande

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: manager/widget good first issue This is a recommended issue for first-time contributors. needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Development

No branches or pull requests

5 participants