Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builderv2: aborting build with ctrl-c does not cleaup the env #9410

Closed
marmarek opened this issue Aug 15, 2024 · 0 comments · Fixed by QubesOS/qubes-builderv2#149
Closed

builderv2: aborting build with ctrl-c does not cleaup the env #9410

marmarek opened this issue Aug 15, 2024 · 0 comments · Fixed by QubesOS/qubes-builderv2#149
Labels
affects-4.3 This issue affects Qubes OS 4.3. C: builder Qubes Builder diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. regression A bug in which a supported feature that worked in a prior Qubes OS release has stopped working. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@marmarek
Copy link
Member

How to file a helpful issue

Qubes OS release

R4.3

Brief summary

Ctrl-C used to cleanup build env (kill DispVM, remove container etc). It doesn't do that anymore.

Steps to reproduce

  1. Start building a package, for example ./qb -c core-vchan-xen package all
  2. Interrupt with ctrl-c

Expected behavior

build env is cleaned up

Actual behavior

DispVM remains running
@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: builder Qubes Builder P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. regression A bug in which a supported feature that worked in a prior Qubes OS release has stopped working. affects-4.3 This issue affects Qubes OS 4.3. labels Aug 15, 2024
@andrewdavidwong andrewdavidwong added the needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. label Aug 16, 2024
fepitre added a commit to fepitre/qubes-builderv2 that referenced this issue Aug 20, 2024
@fepitre
Improve interrupt handling and send signal to current loop
6ee84fe 
Closes QubesOS/qubes-issues#9410
fepitre added a commit to fepitre/qubes-builderv2 that referenced this issue Aug 20, 2024
@fepitre
Improve interrupt handling and send signal to current loop
9b02a38 
Closes QubesOS/qubes-issues#9410
@fepitre fepitre mentioned this issue Aug 20, 2024
Merged
fepitre added a commit to fepitre/qubes-builderv2 that referenced this issue Aug 20, 2024
@fepitre
Improve interrupt handling and send signal to current loop
162474b 
Closes QubesOS/qubes-issues#9410
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.3 This issue affects Qubes OS 4.3. C: builder Qubes Builder diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. regression A bug in which a supported feature that worked in a prior Qubes OS release has stopped working. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve interrupt handling and send signal to current loop fepitre/qubes-builderv2
2 participants
@marmarek @andrewdavidwong