Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builderv2: cleanup does not remove old installer caches #9414

Closed
marmarek opened this issue Aug 16, 2024 · 0 comments · Fixed by QubesOS/qubes-builderv2#151
Closed

builderv2: cleanup does not remove old installer caches #9414

marmarek opened this issue Aug 16, 2024 · 0 comments · Fixed by QubesOS/qubes-builderv2#151
Labels
affects-4.2 This issue affects Qubes OS 4.2. affects-4.3 This issue affects Qubes OS 4.3. C: builder Qubes Builder diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@marmarek
Copy link
Member

marmarek commented Aug 16, 2024

How to file a helpful issue

Qubes OS release

R4.3

Brief summary

Calling qb cleanup all leaves no longer used installer caches.

Steps to reproduce

  1. Build iso with qb installer all
  2. qb cleanup all (or with --dry-run to see what will get removed)

Expected behavior

No longer used installer caches are removed

Actual behavior

Old caches remain.
For example:

$ ls -1 artifacts/cache/installer/
Qubes-202408161327-x86_64/
Qubes-202408162207-x86_64/
chroot/
templates/

templates and chroot should remain, as they will be used for subsequent builds (those should be cleaned up only when explicitly requested). But old Qubes-* should get removed. Not sure about the most recent one - probably should remain as qb installer build (without calling prep) will use that, right?

Yes, I know there is qb cleanup cache --installer, but that will remove also chroot and templates cache - which I want to keep.

@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: builder Qubes Builder P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. affects-4.2 This issue affects Qubes OS 4.2. affects-4.3 This issue affects Qubes OS 4.3. labels Aug 16, 2024
@andrewdavidwong andrewdavidwong added the needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. label Aug 17, 2024
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Sep 12, 2024
egbedo pushed a commit to egbedo/qubes-builderv2 that referenced this issue Oct 21, 2024
cleanup: fix missing bootstrap installer cache

Provide option to "all" to remove absolutely everything that
cleanup commands handle.

Closes QubesOS/qubes-issues#9414

Final commit with changes

cleanup: fix sorting by using LooseVersion lib

final commit

made changes to clamp-changelog-entry-date

made more changes

removed the spurious files and made appropriate changes to scripts

edited script

edited script

retrieved .txt files

edited files

ammended the file

added files

added and removed files

Removed unnecessary files and updated .gitignore

edited the script

edited the script

Replaced date with 1727261746 for reproducibility

final changes

final commit

final changes

shellcheck-error fixes

shellcheck change

fixed clamp-changelog-entry-date

Reverting to fixed-clamp-change

final changes

final changes

shellcheck-error fixes

shellcheck change

fixed clamp-changelog-entry-date

retrieved .txt files

retrieved the .txt files and gitignore

Delete new_rpm_header.txt

Delete new_src_header.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.2 This issue affects Qubes OS 4.2. affects-4.3 This issue affects Qubes OS 4.3. C: builder Qubes Builder diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
2 participants