Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set new device_id when assigning PCI devices with VM settings #9583

Open
5 tasks
marmarek opened this issue Nov 16, 2024 · 0 comments
Open
5 tasks

Set new device_id when assigning PCI devices with VM settings #9583

marmarek opened this issue Nov 16, 2024 · 0 comments
Labels
affects-4.3 This issue affects Qubes OS 4.3. C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.

Comments

@marmarek
Copy link
Member

How to file a helpful issue

The problem you're addressing (if any)

New devices API allows to identify devices not only with a "port id" (which is currently BDF for PCI), but also "device id" (vendor, product etc). qvm-pci tool uses that, but GUI settings don't.

The solution you'd like

Fill in device id too. This also means ensuring such assignment can is properly handled when opening the settings, and unassigning the device. Including the case when the device is not physically present anymore.

The value to a user, and who that user might be

More strict device assignments.

Completion criteria checklist

(This section is for developer use only. Please do not modify it.)

  • fill in device_id when assigning
  • ensure loading assignments with device_id works
  • decide what to do about existing assignments without device_id (should those get device_id on save?)
  • ensure non-present devices with device_id set are handled properly (should those get some metadata extracted from the device id, instead of just saying "unknown"?)
  • same as above but when device with the same port-id is present but has different device_id - especially ensure the device_id won't get "updated"
@marmarek marmarek added T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. affects-4.3 This issue affects Qubes OS 4.3. labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.3 This issue affects Qubes OS 4.3. C: manager/widget P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
None yet
Development

No branches or pull requests

1 participant