Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏡 Home Library Service: Part 2 #2

Open
wants to merge 45 commits into
base: dev
Choose a base branch
from

Conversation

Quiddlee
Copy link
Owner

@Quiddlee Quiddlee commented Mar 15, 2024

  1. Task: link

  2. Screenshot:
    image
    image

  3. Deploy: link

  4. Done 12.03.2024 / deadline 26.03.2024

  5. Score: 360/ 360

👌 Basic Scope

1) Containerization, Docker

  • +20 Readme.md has instruction how to run application
  • +30 user-defined bridge is created and configured
  • +30 container auto restart after crash
  • +20 application is restarting upon changes implemented into src folder
  • +30 database files and logs to be stored in volumes instead of container

2) Database (PostgreSQL) & ORM

  • +20 Users data is stored in PostgreSQL database and typeorm / prisma interacts with the database to manipulate data.
  • +20 Artists data is stored in PostgreSQL database and typeorm / prisma interacts with the database to manipulate data.
  • +20 Albums data is stored in PostgreSQL database and typeorm / prisma interacts with the database to manipulate data.
  • +20 Tracks data is stored in PostgreSQL database and typeorm / prisma interacts with the database to manipulate data.
  • +20 Favorites data is stored in PostgreSQL database and typeorm / prisma interacts with the database to manipulate data.

📍 Advanced Scope

1) Containerization, Docker

  • +20 Final size of the Docker image with application is less than 500 MB
  • +10 Implemented npm script for vulnerabilities scanning (free solution)
  • +20 Your built image is pushed to DockerHub

2) Database & ORM

  • +30 Migrations are used to create database entities
  • +10 Variables used for connection to database to be stored in .env
  • +10 typeorm decorators or prisma relations create relations between entities
  • +30 Local PostgreSQL installation is not required for task check, connection is implemented to database stored in docker container (on the basis of the previous task)

📛 Forfeits

  • -20 In case specific image is not used (it is required to use images like postgres and node, but not ubuntu with installation of node or postgres)
  • -20 Postgres container is not configured as dependency for application container
  • -10 for each failing test with npm run test
  • -20 docker-compose.yml contains hardcoded variables
  • -30% of total task score Commits after deadline, except commits that affect only Readme.md, .gitignore, etc.
  • -40 No Pull Request created
  • -20 PR description is incorrect
  • -40 No separate development branch
  • -10 for each failing test with npm run test
  • -20 Less than 3 commits in the development branch, not taking into account commits, making changes only in Readme.md or similar files (tsconfig.json, .gitignore, .prettierrc.json, etc.)
  • -10 points for each error either on npm run lint on the basis of the local config or for compilation errors on the basis of the local tsconfig (errors not warnings).

@Quiddlee Quiddlee changed the title sprint 2 🏡 Home Library Service: Part 2 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant