generated from rolling-scopes-school/nodejs-course-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏡 Home Library Service: Part 3 #3
Open
Quiddlee
wants to merge
20
commits into
sprint-2/containerization-database-orm
Choose a base branch
from
sprint-3/logging-error-authentication-authorization
base: sprint-2/containerization-database-orm
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
🏡 Home Library Service: Part 3 #3
Quiddlee
wants to merge
20
commits into
sprint-2/containerization-database-orm
from
sprint-3/logging-error-authentication-authorization
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quiddlee
changed the title
Sprint 3/logging error authentication authorization
🏡 Home Library Service: Part 3
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: link
Screenshot:
Deploy: link
Done 01.04.2024 / deadline 02.04.2024
Score: 320 / 320
👌 Basic Scope
1) Logging & Error Handling:
LoggingService
is implemented and used for loggingException Filter
is implemented and used for handling exceptions during request processingurl
,query parameters
,body
) and response withstatus code
is implemented.http status code
and errors logging.uncaughtException
event.unhandledRejection
event.2) Authentication and Authorization:
/auth/signup
implemented correctly, related logic is divided between controller and corresponding service/auth/login
has been implemented, related logic is divided between controller and corresponding serviceUser
password
saved into database as hashJWT
payload containsuserId
andlogin
, secret key is saved in.env
./auth/signup
,/auth/login
,/doc
and/
.📍 Advanced Scope
1) Logging & Error Handling:
Logs with configured level to be registered as well as other higher priority levels. For example if you set level 2, all messages with levels 0, 1 and 2 should be logged. You should use Nest.js logging levels.
2) Authentication and Authorization:
/auth/refresh
implemented correctly, related logic is divided between controller and corresponding service📛 Forfeits
(for authentication and authorization module tests to be run with
npm run test:auth
)npm run lint
on the basis of the local config or for compilation errors on the basis of the local tsconfig (errors
notwarnings
).Readme.md
or similar files (tsconfig.json
,.gitignore
,.prettierrc.json
, etc.)