Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rework MAD cleanup handles #817

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Alystrasz
Copy link
Contributor

Changes

  • Mod is not marked as successfully installed when the process failed;
  • When mod downloading/extraction fails, mod directory is removed.

Testing

  1. Install this PR;
  2. Enable MAD (allow_mod_auto_download 1);
  3. Try to join Space battle server and cancel mod downloading/extraction;
  4. Check your local profile, the remote mod should not appear in the runtime/remote/mods directory.

Closes #756.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Sep 7, 2024
@Alystrasz
Copy link
Contributor Author

Waiting for #815 to be merged so we have a simple way to cancel MAD process.

@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Sep 7, 2024
@github-actions github-actions bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Sep 7, 2024
@GeckoEidechse GeckoEidechse added the MAD Related to mod-auto-download label Sep 7, 2024
@Alystrasz Alystrasz added the depends on another PR Blocked until the PR it depends on is merged label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on another PR Blocked until the PR it depends on is merged MAD Related to mod-auto-download needs code review Changes from PR still need to be reviewed in code needs testing Changes from the PR still need to be tested
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Issue on mod download failure
2 participants